Skip to content

Fix Metal tests to SKIP instead of FAIL when Apple Silicon GPU is unavailable - #17

Closed
Kwizatz with Copilot wants to merge 2 commits into
masterfrom
copilot/fix-failing-github-actions-job
Closed

Fix Metal tests to SKIP instead of FAIL when Apple Silicon GPU is unavailable#17
Kwizatz with Copilot wants to merge 2 commits into
masterfrom
copilot/fix-failing-github-actions-job

Conversation

Copilot AI commented Aug 6, 2026

Copy link
Copy Markdown

14 Metal tests were reporting FAILED on the macOS CI runner (which lacks Apple Silicon) instead of SKIPPED, because they used ASSERT_NE(renderer, nullptr) rather than GTEST_SKIP() after a failed renderer construction.

Changes

  • tests/RendererParityTests.cpp / tests/ComputeTests.cpp: Replace ASSERT_NE ( renderer, nullptr ) with the established skip pattern:
    if ( renderer == nullptr )
    {
        GTEST_SKIP() << "Metal renderer unavailable on this host.";
    }
  • tests/RendererParityTests.cpp (shadow/environment tests): Switch from ConstructRenderer(...) — which throws on unavailable backends, causing an uncaught-exception failure — to TryConstructRenderer(...), which returns nullptr and lets the skip guard above fire cleanly.
  • tests/RenderTestWindow.h: Add a TryConstructRenderer overload accepting RendererSettings to support the above.

…vailable

Co-authored-by: Kwizatz <2333297+Kwizatz@users.noreply.github.com>
Copilot AI changed the title [WIP] Fix failing GitHub Actions job clang Fix Metal tests to SKIP instead of FAIL when Apple Silicon GPU is unavailable Aug 6, 2026
Copilot AI requested a review from Kwizatz August 6, 2026 00:39
@Kwizatz

Kwizatz commented Aug 6, 2026

Copy link
Copy Markdown
Member

@copilot Please fix ALL CI builds, looks like we have 3 failures.

@Kwizatz Kwizatz left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are 3 other builds failing, none should fail.

@Kwizatz

Kwizatz commented Aug 7, 2026

Copy link
Copy Markdown
Member

Merged

@Kwizatz Kwizatz closed this Aug 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants