Closed
Fix Metal tests to SKIP instead of FAIL when Apple Silicon GPU is unavailable#17
Conversation
…vailable Co-authored-by: Kwizatz <2333297+Kwizatz@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix failing GitHub Actions job clang
Fix Metal tests to SKIP instead of FAIL when Apple Silicon GPU is unavailable
Aug 6, 2026
Member
|
@copilot Please fix ALL CI builds, looks like we have 3 failures. |
Kwizatz
reviewed
Aug 6, 2026
Kwizatz
left a comment
Member
There was a problem hiding this comment.
There are 3 other builds failing, none should fail.
Copilot stopped work on behalf of
Kwizatz due to an error
August 6, 2026 18:35
Member
|
Merged |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
14 Metal tests were reporting FAILED on the macOS CI runner (which lacks Apple Silicon) instead of SKIPPED, because they used
ASSERT_NE(renderer, nullptr)rather thanGTEST_SKIP()after a failed renderer construction.Changes
tests/RendererParityTests.cpp/tests/ComputeTests.cpp: ReplaceASSERT_NE ( renderer, nullptr )with the established skip pattern:tests/RendererParityTests.cpp(shadow/environment tests): Switch fromConstructRenderer(...)— which throws on unavailable backends, causing an uncaught-exception failure — toTryConstructRenderer(...), which returnsnullptrand lets the skip guard above fire cleanly.tests/RenderTestWindow.h: Add aTryConstructRendereroverload acceptingRendererSettingsto support the above.