Skip to content

[dataprotection] Code generation: update services and models - #1773

Merged
gcatanese merged 1 commit into
mainfrom
sdk-automation/dataprotection
Aug 27, 2026
Merged

gcatanese merged 1 commit into
mainfrom
sdk-automation/dataprotection

Conversation

@AdyenAutomationBot

Copy link
Copy Markdown
Collaborator

This PR contains the automated changes for the dataprotection service.

The commit history of this PR reflects the adyen-openapi commits that have been applied.

@AdyenAutomationBot
AdyenAutomationBot requested a review from a team as a code owner August 27, 2026 07:49

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the SDK generation log for the dataprotection service and modifies the generated dataProtectionApi.ts file to import ServiceError and add void statements to bypass unused variable checks. The review feedback suggests improving the generator templates to merge duplicate imports, remove unused imports like ServiceError, and use idiomatic TypeScript import type statements for type-only references instead of using void statements.

Comment on lines +17 to +22
import { ServiceError } from "../../typings/dataProtection/models";
import { SubjectErasureByPspReferenceRequest } from "../../typings/dataProtection/models";
import { SubjectErasureResponse } from "../../typings/dataProtection/models";
void ServiceError;
void SubjectErasureByPspReferenceRequest;
void SubjectErasureResponse;

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The generated code imports multiple models from the same module using separate import statements and uses void statements to bypass unused variable checks.

  1. Duplicate Imports: Multiple imports from ../../typings/dataProtection/models should be merged.
  2. Unused Import: ServiceError is imported but never used in this file.
  3. Type-Only Imports: SubjectErasureByPspReferenceRequest and SubjectErasureResponse are only used as type annotations. Using import type is the idiomatic TypeScript way to import type-only dependencies, which avoids triggering unused import warnings and prevents emitting unnecessary void statements in the compiled JavaScript.

Since this is generated code, please consider updating the generator templates to merge imports, omit unused models, and use import type for type-only references.

Suggested change
import { ServiceError } from "../../typings/dataProtection/models";
import { SubjectErasureByPspReferenceRequest } from "../../typings/dataProtection/models";
import { SubjectErasureResponse } from "../../typings/dataProtection/models";
void ServiceError;
void SubjectErasureByPspReferenceRequest;
void SubjectErasureResponse;
import type { SubjectErasureByPspReferenceRequest, SubjectErasureResponse } from "../../typings/dataProtection/models";

@AdyenAutomationBot
AdyenAutomationBot force-pushed the sdk-automation/dataprotection branch from 355d4b4 to 6a7e89a Compare August 27, 2026 12:21
@gcatanese
gcatanese added this pull request to the merge queue Aug 27, 2026
Merged via the queue into main with commit 3c88813 Aug 27, 2026
4 checks passed
@gcatanese
gcatanese deleted the sdk-automation/dataprotection branch August 27, 2026 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants