Skip to content

[payout] Code generation: update services and models - #1772

Merged
gcatanese merged 1 commit into
mainfrom
sdk-automation/payout
Aug 27, 2026
Merged

gcatanese merged 1 commit into
mainfrom
sdk-automation/payout

Conversation

@AdyenAutomationBot

Copy link
Copy Markdown
Collaborator

This PR contains the automated changes for the payout service.

The commit history of this PR reflects the adyen-openapi commits that have been applied.

@AdyenAutomationBot
AdyenAutomationBot requested a review from a team as a code owner August 27, 2026 07:49

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the generated SDK code for the payout service, including updating the generation log and adding dummy void statements to suppress unused import warnings. The feedback suggests updating the generator templates to use TypeScript's import type syntax instead of these void statements. This approach would eliminate runtime overhead, improve tree-shaking, and avoid importing unused types like ServiceError.

Comment on lines +24 to +30
void ServiceError;
void StoreDetailAndSubmitRequest;
void StoreDetailAndSubmitResponse;
void StoreDetailRequest;
void StoreDetailResponse;
void SubmitRequest;
void SubmitResponse;

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

These void <Type> statements are used to suppress unused import warnings. However, since these imports are only used as types in this file, a much cleaner and standard TypeScript approach is to use import type (e.g., import type { StoreDetailRequest } from ...).

Using import type has several benefits:

  1. No Runtime Overhead: Type-only imports are completely erased during compilation, so there are no runtime references.
  2. Better Tree-Shaking: It ensures that unused models can be safely tree-shaken by bundlers, reducing the final bundle size for consumers.
  3. Cleaner Code: It eliminates the need for dummy runtime statements like void StoreDetailRequest;.

Additionally, ServiceError is imported but completely unused in this file.

Since this is automated code generation, please update the generator templates to:

  • Use import type for type-only imports.
  • Avoid importing unused models like ServiceError.
  • Remove these void statements entirely.

Comment on lines +20 to +22
void PayoutRequest;
void PayoutResponse;
void ServiceError;

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

These void <Type> statements are used to suppress unused import warnings. Since PayoutRequest and PayoutResponse are only used as types in this file, they should be imported using import type (e.g., import type { PayoutRequest } from ...).

This would allow you to:

  1. Remove these dummy void statements entirely.
  2. Avoid importing ServiceError which is completely unused in this file.
  3. Improve tree-shaking and reduce bundle size for SDK consumers, as type-only imports are completely erased at compile time.

Please update the generator templates to adopt import type for type-only imports and remove these unnecessary void statements.

Comment thread src/services/payout/reviewingApi.ts Outdated
Comment on lines +20 to +22
void ModifyRequest;
void ModifyResponse;
void ServiceError;

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

These void <Type> statements are used to suppress unused import warnings. Since ModifyRequest and ModifyResponse are only used as types in this file, they should be imported using import type (e.g., import type { ModifyRequest } from ...).

This would allow you to:

  1. Remove these dummy void statements entirely.
  2. Avoid importing ServiceError which is completely unused in this file.
  3. Improve tree-shaking and reduce bundle size for SDK consumers, as type-only imports are completely erased at compile time.

Please update the generator templates to adopt import type for type-only imports and remove these unnecessary void statements.

@gcatanese
gcatanese added this pull request to the merge queue Aug 27, 2026
Merged via the queue into main with commit 66d3a0b Aug 27, 2026
4 checks passed
@gcatanese
gcatanese deleted the sdk-automation/payout branch August 27, 2026 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants