Skip to content

[capital] Code generation: update services and models - #1765

Merged
gcatanese merged 1 commit into
mainfrom
sdk-automation/capital
Aug 27, 2026
Merged

gcatanese merged 1 commit into
mainfrom
sdk-automation/capital

Conversation

@AdyenAutomationBot

Copy link
Copy Markdown
Collaborator

This PR contains the automated changes for the capital service.

The commit history of this PR reflects the adyen-openapi commits that have been applied.

@AdyenAutomationBot
AdyenAutomationBot requested a review from a team as a code owner August 27, 2026 07:49

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the auto-generated SDK files for the capital service, including metadata updates and the addition of void statements to bypass TypeScript's unused local variable checks. The review feedback correctly identifies that DefaultErrorResponseEntity is imported and referenced with a void statement across multiple API classes without actually being used. This pattern bypasses compiler checks but leaves dead imports in the compiled output, which hinders tree-shaking and increases bundle size. It is recommended to update the generator templates to only import and emit void statements for models that are actively referenced.

Comment on lines +20 to +30
import { DefaultErrorResponseEntity } from "../../typings/capital/models";
import { FinancingType } from "../../typings/capital/models";
import { GetDynamicOffersResponse } from "../../typings/capital/models";
import { GrantOffer } from "../../typings/capital/models";
void CalculateGrantOfferRequest;
void CalculatedGrantOffer;
void CreateGrantOfferRequest;
void DefaultErrorResponseEntity;
void FinancingType;
void GetDynamicOffersResponse;
void GrantOffer;

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The DefaultErrorResponseEntity model is imported and referenced with a void statement, but it is never actually used in this API class. This pattern bypasses TypeScript's noUnusedLocals check but leaves dead imports in the compiled JavaScript, which prevents effective tree-shaking and increases bundle size.

Since this code is auto-generated, the OpenAPI Generator templates should be updated to only import and emit void statements for models that are actually referenced in the API methods.

Suggested change
import { DefaultErrorResponseEntity } from "../../typings/capital/models";
import { FinancingType } from "../../typings/capital/models";
import { GetDynamicOffersResponse } from "../../typings/capital/models";
import { GrantOffer } from "../../typings/capital/models";
void CalculateGrantOfferRequest;
void CalculatedGrantOffer;
void CreateGrantOfferRequest;
void DefaultErrorResponseEntity;
void FinancingType;
void GetDynamicOffersResponse;
void GrantOffer;
import { FinancingType } from "../../typings/capital/models";
import { GetDynamicOffersResponse } from "../../typings/capital/models";
import { GrantOffer } from "../../typings/capital/models";
void CalculateGrantOfferRequest;
void CalculatedGrantOffer;
void CreateGrantOfferRequest;
void FinancingType;
void GetDynamicOffersResponse;
void GrantOffer;

Comment on lines +17 to +20
import { DefaultErrorResponseEntity } from "../../typings/capital/models";
import { GrantAccount } from "../../typings/capital/models";
void DefaultErrorResponseEntity;
void GrantAccount;

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The DefaultErrorResponseEntity model is imported and referenced with a void statement, but it is never actually used in this API class. This pattern bypasses TypeScript's noUnusedLocals check but leaves dead imports in the compiled JavaScript, which prevents effective tree-shaking and increases bundle size.

Since this code is auto-generated, the OpenAPI Generator templates should be updated to only import and emit void statements for models that are actually referenced in the API methods.

Suggested change
import { DefaultErrorResponseEntity } from "../../typings/capital/models";
import { GrantAccount } from "../../typings/capital/models";
void DefaultErrorResponseEntity;
void GrantAccount;
import { GrantAccount } from "../../typings/capital/models";
void GrantAccount;

Comment thread src/services/capital/grantOffersApi.ts Outdated
Comment on lines +17 to +22
import { DefaultErrorResponseEntity } from "../../typings/capital/models";
import { GrantOffer } from "../../typings/capital/models";
import { GrantOffers } from "../../typings/capital/models";
void DefaultErrorResponseEntity;
void GrantOffer;
void GrantOffers;

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The DefaultErrorResponseEntity model is imported and referenced with a void statement, but it is never actually used in this API class. This pattern bypasses TypeScript's noUnusedLocals check but leaves dead imports in the compiled JavaScript, which prevents effective tree-shaking and increases bundle size.

Since this code is auto-generated, the OpenAPI Generator templates should be updated to only import and emit void statements for models that are actually referenced in the API methods.

Suggested change
import { DefaultErrorResponseEntity } from "../../typings/capital/models";
import { GrantOffer } from "../../typings/capital/models";
import { GrantOffers } from "../../typings/capital/models";
void DefaultErrorResponseEntity;
void GrantOffer;
void GrantOffers;
import { GrantOffer } from "../../typings/capital/models";
import { GrantOffers } from "../../typings/capital/models";
void GrantOffer;
void GrantOffers;

Comment thread src/services/capital/grantsApi.ts Outdated
Comment on lines +17 to +30
import { DefaultErrorResponseEntity } from "../../typings/capital/models";
import { Disbursement } from "../../typings/capital/models";
import { DisbursementInfoUpdate } from "../../typings/capital/models";
import { Disbursements } from "../../typings/capital/models";
import { Grant } from "../../typings/capital/models";
import { GrantInfo } from "../../typings/capital/models";
import { Grants } from "../../typings/capital/models";
void DefaultErrorResponseEntity;
void Disbursement;
void DisbursementInfoUpdate;
void Disbursements;
void Grant;
void GrantInfo;
void Grants;

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The DefaultErrorResponseEntity model is imported and referenced with a void statement, but it is never actually used in this API class. This pattern bypasses TypeScript's noUnusedLocals check but leaves dead imports in the compiled JavaScript, which prevents effective tree-shaking and increases bundle size.

Since this code is auto-generated, the OpenAPI Generator templates should be updated to only import and emit void statements for models that are actually referenced in the API methods.

Suggested change
import { DefaultErrorResponseEntity } from "../../typings/capital/models";
import { Disbursement } from "../../typings/capital/models";
import { DisbursementInfoUpdate } from "../../typings/capital/models";
import { Disbursements } from "../../typings/capital/models";
import { Grant } from "../../typings/capital/models";
import { GrantInfo } from "../../typings/capital/models";
import { Grants } from "../../typings/capital/models";
void DefaultErrorResponseEntity;
void Disbursement;
void DisbursementInfoUpdate;
void Disbursements;
void Grant;
void GrantInfo;
void Grants;
import { Disbursement } from "../../typings/capital/models";
import { DisbursementInfoUpdate } from "../../typings/capital/models";
import { Disbursements } from "../../typings/capital/models";
import { Grant } from "../../typings/capital/models";
import { GrantInfo } from "../../typings/capital/models";
import { Grants } from "../../typings/capital/models";
void Disbursement;
void DisbursementInfoUpdate;
void Disbursements;
void Grant;
void GrantInfo;
void Grants;

@gcatanese
gcatanese added this pull request to the merge queue Aug 27, 2026
Merged via the queue into main with commit 3627d49 Aug 27, 2026
4 checks passed
@gcatanese
gcatanese deleted the sdk-automation/capital branch August 27, 2026 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants