Skip to content

[balancecontrol] Code generation: update services and models - #1763

Merged
gcatanese merged 1 commit into
mainfrom
sdk-automation/balancecontrol
Aug 27, 2026
Merged

gcatanese merged 1 commit into
mainfrom
sdk-automation/balancecontrol

Conversation

@AdyenAutomationBot

Copy link
Copy Markdown
Collaborator

This PR contains the automated changes for the balancecontrol service.

The commit history of this PR reflects the adyen-openapi commits that have been applied.

@AdyenAutomationBot
AdyenAutomationBot requested a review from a team as a code owner August 27, 2026 07:49

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the SDK generation log for the balance control service and introduces void statements in balanceControlApi.ts to suppress unused import warnings for BalanceTransferRequest and BalanceTransferResponse. The reviewer suggests using a more idiomatic TypeScript approach by importing these models as types (import type) instead of using the void statement workaround.

Comment on lines +17 to +20
import { BalanceTransferRequest } from "../../typings/balanceControl/models";
import { BalanceTransferResponse } from "../../typings/balanceControl/models";
void BalanceTransferRequest;
void BalanceTransferResponse;

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

These void statements are used as a workaround to prevent unused import warnings/errors. Since these models are only used as types in this file, a cleaner and more idiomatic TypeScript approach is to use import type for these imports. Consider updating the OpenAPI generator configuration or templates to generate import type for type-only imports, which will eliminate the need for these void statement workarounds.

Suggested change
import { BalanceTransferRequest } from "../../typings/balanceControl/models";
import { BalanceTransferResponse } from "../../typings/balanceControl/models";
void BalanceTransferRequest;
void BalanceTransferResponse;
import type { BalanceTransferRequest, BalanceTransferResponse } from "../../typings/balanceControl/models";

@AdyenAutomationBot
AdyenAutomationBot force-pushed the sdk-automation/balancecontrol branch from debd686 to 5da9b4a Compare August 27, 2026 12:21
@gcatanese
gcatanese added this pull request to the merge queue Aug 27, 2026
Merged via the queue into main with commit 5947c08 Aug 27, 2026
4 checks passed
@gcatanese
gcatanese deleted the sdk-automation/balancecontrol branch August 27, 2026 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants