Repository navigation
[balancecontrol] Code generation: update services and models - #1763
Conversation
There was a problem hiding this comment.
Code Review
This pull request updates the SDK generation log for the balance control service and introduces void statements in balanceControlApi.ts to suppress unused import warnings for BalanceTransferRequest and BalanceTransferResponse. The reviewer suggests using a more idiomatic TypeScript approach by importing these models as types (import type) instead of using the void statement workaround.
| import { BalanceTransferRequest } from "../../typings/balanceControl/models"; | ||
| import { BalanceTransferResponse } from "../../typings/balanceControl/models"; | ||
| void BalanceTransferRequest; | ||
| void BalanceTransferResponse; |
There was a problem hiding this comment.
These void statements are used as a workaround to prevent unused import warnings/errors. Since these models are only used as types in this file, a cleaner and more idiomatic TypeScript approach is to use import type for these imports. Consider updating the OpenAPI generator configuration or templates to generate import type for type-only imports, which will eliminate the need for these void statement workarounds.
| import { BalanceTransferRequest } from "../../typings/balanceControl/models"; | |
| import { BalanceTransferResponse } from "../../typings/balanceControl/models"; | |
| void BalanceTransferRequest; | |
| void BalanceTransferResponse; | |
| import type { BalanceTransferRequest, BalanceTransferResponse } from "../../typings/balanceControl/models"; |
debd686 to
5da9b4a
Compare
This PR contains the automated changes for the
balancecontrolservice.The commit history of this PR reflects the
adyen-openapicommits that have been applied.