Repository navigation
Export Session Authentication types - #1760
Merged
gcatanese merged 1 commit intoAug 24, 2026
Merged
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request exports the sessionAuthentication models under the Types namespace in src/typings/index.ts and adds a corresponding unit test in src/tests/sessionAuthenticationApi.spec.ts to verify that AuthenticationSessionRequest is correctly exported. I have no feedback to provide.
gcatanese
force-pushed
the
fix/1751-export-session-authentication-types
branch
from
August 24, 2026 09:23
b0057cf to
25dfe4b
Compare
Contributor
|
Thank you @shin4141 for your contribution 🎉 |
gcatanese
approved these changes
Aug 24, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
SessionAuthenticationAPIis publicly available, but its generated request and response models are not exposed through the publicTypesnamespace.Fix
Add the missing manually maintained
sessionAuthenticationnamespace export insrc/typings/index.tsand cover it through the public package entrypoint.Tests
npm run buildnpm test -- --runInBand src/__tests__/sessionAuthenticationApi.spec.ts(4 passed)npm run lintnpm test -- --runInBand(53 suites and 620 tests passed; the five existingcapital.spec.tsfailures reproduce on pristine main at the base SHA)git diff --checkIssue
Fixes #1751
AI assistance
AI assistance was used during investigation and verification. Shin reviewed the final change, tests, and scope and owns the submission.