Bump archinstall to 4.4; move Plymouth into Phase A#16
Merged
Conversation
archinstall 4.4 adds a `bootloader_config.plymouth` field that installs and configures the boot splash during the install (initramfs hook, `quiet splash` on the cmdline, theme, initramfs rebuild). Render `plymouth.theme` into it and retire the Phase B plymouth stage. - Bump pinned archinstall Version 4.3 -> 4.4; regenerate goldens (version field only — no behavioural drift). - Render Plymouth in `internal/archinstall`; `plymouth` is omitempty so configs without a theme stay byte-identical. - Restrict `plymouth.theme` to archinstall's 10 built-in themes: archinstall sys.exit(1)s on an unknown value, so reject it at validation rather than aborting a destructive install. Custom themes are unsupported via this path. - Drop `grub.cmdline_extra` (archinstall now supplies `quiet splash`; it was only ever applied by the plymouth stage). - Remove the Phase B plymouth stage plus the now-dead ensureKernelParam / regenerateBootConfig helpers and the plymouth-only test files. Side effect: resolves plymouth-bootctl-update-fails-systemd-boot.md — the always-on Phase B `bootctl update` path that broke systemd-boot bootstrap no longer exists. VM-validation-pending: the bootloader_config.plymouth shape is reverse- engineered from 4.4 source and must be confirmed on a real run. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
archinstall 4.4 released. This bumps our pinned schema version and takes advantage of its new
bootloader_config.plymouthfield to move Plymouth setup from a Phase B stage into archinstall (Phase A).4.3 → 4.4 review
Diffed the schema-relevant code (config/creds parsing in
args.py,lib/models/*,configuration.py). No breaking changes to anything we render — config input parsing, the creds format (!root-password/users[].!password),disk_configserialization, and the--config/--creds/--silentflags are all unchanged. New 4.4 additions are optional (locale_config.console_fontdefaults if absent; networkiwd;share-logsubcommand) — none required.The one field we adopt is
bootloader_config.plymouth: when set, archinstall installs plymouth, inserts the initramfs hook, appendsquiet splashto the kernel cmdline, runsplymouth-set-default-themeand rebuilds the initramfs — all during the install.Changes
Version4.3 → 4.4; regenerate goldens (version field only, no behavioural drift).plymouth.themeintobootloader_config.plymouth(omitempty→ unset configs stay byte-identical).plymouth.themeto archinstall's 10 built-in themes. archinstallsys.exit(1)s on an unknown theme, so we reject it at validation rather than aborting a destructive Phase A. Custom Plymouth themes are no longer supported via this path — deliberate tradeoff.grub.cmdline_extra— archinstall now suppliesquiet splash, and it was only ever applied by the plymouth stage.ensureKernelParam/regenerateBootConfighelpers and plymouth-only test files.New behaviour proven by inline field-assertion tests; goldens unchanged except the version bump.
Side effect: a bug goes away
This resolves
docs/bugs/plymouth-bootctl-update-fails-systemd-boot.md— the always-on Phase Bbootctl updatethat broke every systemd-boot bootstrap no longer exists.The
bootloader_config.plymouthshape is reverse-engineered from 4.4 source. Per the CLAUDE.md archinstall-drift rule, confirm on a real archinstall run in a VM that thespinnertheme is set andquiet splashreaches the cmdline before trusting on hardware. Added a tracking row indocs/vm-validation.md.🤖 Generated with Claude Code