BayDAG Contribution #2: Enhanced Disaggregate Accessibility Merging#768
Merged
jpn-- merged 4 commits intoActivitySim:mainfrom Mar 28, 2024
Merged
Conversation
Contributor
|
Just commenting to say that these are necessary for Met Council's Phase 2 ActivitySim model. |
dhensle
force-pushed
the
BayDAG_cont2_disaggregate_accessibility
branch
from
c005042 to
ea25a66
Compare
i-am-sijia
approved these changes
Mar 19, 2024
Member
|
This non-trivial PR has no testing to confirm it works. |
jpn--
requested changes
Mar 26, 2024
jpn--
approved these changes
Mar 28, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request gives the user greater flexibility to join disaggregate accessibilities to the households / person tables. The original design for the model just joined the disaggregate accessibilities to the household table by a set of auto ownership and home zone. This was insufficient for the purpose of joining all auto ownership levels created in the disaggregate accessibilities model so they could be applied to the alternatives in the auto ownership model.
See the SANDAG ABM3 configs for an example implementation: yaml and annotator.
Required for SANDAG ABM3 production? -- yes