Selecting choices from joint tour participant ID column explicitly;#653
Merged
jpn-- merged 1 commit intoActivitySim:developfrom Feb 6, 2024
Merged
Selecting choices from joint tour participant ID column explicitly;#653jpn-- merged 1 commit intoActivitySim:developfrom
jpn-- merged 1 commit intoActivitySim:developfrom
Conversation
In estimation mode, the index of survey_participants_df does not reflect participant_id (when tested using real survey data). This change uses the ID column directly to select the choice set rather than relying on the index.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In estimation mode, the index of survey_participants_df does not reflect participant_id (as tested by using PSRC survey data). This change uses the ID column directly to select the choice set instead of assuming an index has been properly set.
This was tested and works in both estimation and simulation mode. Perhaps it's preferable to ensure the index is set upstream, but this was the clearest route for me to continue producing estimation data bundles.