fix(security): Credential injection file path allowlist (#183) - #207
Merged
Conversation
…rary file writes (#183) Add strict allowlist validation to POST /api/agents/{name}/credentials/inject so only known credential files (.env, .mcp.json, .mcp.json.template, .credentials.enc) can be written. Previously any authenticated owner could write attacker-controlled content to arbitrary paths inside the agent container (pentest finding 3.2.6, CVSS 4.8). Defense in depth: allowlist enforced at both backend and agent layers. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
{.env, .mcp.json, .mcp.json.template, .credentials.enc}) to the credential injection endpoint, blocking arbitrary file writes inside agent containers/home/developer/Test plan
/hello/anyfile.html) — confirmed blocked with HTTP 400.envinjection still succeeds../../etc/passwd) blockedCLAUDE.md,.bashrc) blockedtests/unit/test_credential_inject_allowlist.py)Closes #183
🤖 Generated with Claude Code