Fix LoadFromBag assumptions causing C++ exceptions during serialization (backport #438)#470
Conversation
|
@wep21 Looks like nav2 broke ABI again with their rosdep sources. Thoughts on only compile nav2 from source on rolling? |
|
@Ryanf55 How about adding if condition into vcs import block? |
To make it only import them |
|
Interestingly, the |
|
@wep21 Thoughts on trying to get this fixed, and once it's merged, we do another bugfix release for all the distros? |
27cff71 to
7d82810
Compare
|
Rebased, fixed with |
…on (#438) Fix LoadFromBag assumptions * Not all bags have only GridMap messages * Not all bags have GridMap on the right topic * Add test for trying to load a grid map from a bag that doesn't contain it on the expected topic * Add nullptr check on reader messages * Remove unused include * Don't skip reporting when tests fail (cherry picked from commit 25a1ea5)
7d82810 to
9c2c6fb
Compare
Description
Demo
Details
I uploaded a super small bagfile of two chatter topics. It's very small:
It might be better to construct the bag file on the fly in the test case, but that would take much more time than what I did here.
Issue
Solves #401
This is an automatic backport of pull request #438 done by Mergify.