Skip to content

Fix IS-05 transport constraints mismatch diagnostic - #908

Open
iibaranov-IG wants to merge 1 commit into
AMWA-TV:masterfrom
iibaranov-IG:fix/is05-constraints-count-diagnostic
Open

iibaranov-IG wants to merge 1 commit into
AMWA-TV:masterfrom
iibaranov-IG:fix/is05-constraints-count-diagnostic

Conversation

@iibaranov-IG

@iibaranov-IG iibaranov-IG commented Sep 2, 2026 •

Copy link
Copy Markdown

Summary

  • return a clear test failure when the number of transport_params in /staged does not match the advertised constraints
  • avoid an IndexError when a Node returns an empty constraints array
  • cover matching, missing, extra, and empty transport-parameter legs with focused tests

Validation

At signed commit f9e0fc875cefb6e2097d70219f50fa41affc4653:

  • .venv/bin/python -m unittest discover -s tests -v — 4 tests pass
  • .venv/bin/flake8 nmostesting/IS05Utils.py tests/test_is05_transport_params.py
  • Python bytecode compilation for changed Python files
  • git diff --check

Closes #843

@iibaranov-IG
iibaranov-IG force-pushed the fix/is05-constraints-count-diagnostic branch from 88f72a5 to f9e0fc8 Compare September 8, 2026 14:36
@garethsb

Copy link
Copy Markdown
Contributor

LGTM but same comment about unit tests as #915 (comment)

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[IS-05-01] test_24 IndexError: list index out of range

2 participants