Repository navigation
Fix IS-05 transport constraints mismatch diagnostic - #908
Open
iibaranov-IG wants to merge 1 commit into
Open
iibaranov-IG wants to merge 1 commit into
iibaranov-IG wants to merge 1 commit into
Conversation
iibaranov-IG
force-pushed
the
fix/is05-constraints-count-diagnostic
branch
from
September 8, 2026 14:36
88f72a5 to
f9e0fc8
Compare
Contributor
|
LGTM but same comment about unit tests as #915 (comment) |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
transport_paramsin/stageddoes not match the advertised constraintsIndexErrorwhen a Node returns an empty constraints arrayValidation
At signed commit
f9e0fc875cefb6e2097d70219f50fa41affc4653:.venv/bin/python -m unittest discover -s tests -v— 4 tests pass.venv/bin/flake8 nmostesting/IS05Utils.py tests/test_is05_transport_params.pygit diff --checkCloses #843