Repository navigation
IS-10 Auth Tests: check missing public key and replaced Auth server with mock - #599
Conversation
andrewbonney
left a comment
There was a problem hiding this comment.
Sorry for not getting to this sooner. The changes look good generally. I think the main thing that's missing is some documentation - particularly around how to configure things so that the mock authorization server can be chosen (and advertised by the DNS server) when there isn't one available locally.
Also as noted inline, if the mock auth server is more generally useful for the other auth tests then its activation should maybe be handled earlier. The new public key test may then need disabling in the case where a user chooses to use their own external auth server as the testing tool would have no control over rotating the public keys.
|
@lo-simon Does this PR need rebasing? It's currently showing 100 changed files over 185 commits... |
…OUT (thnak you @prince-chrismc suggestion)
…dd more tests on token fetch endpoint
f7496f3 to
8832f99
Compare
|
@lo-simon I rebased again without the old merge commit and that seems to have made GitHub happier I hope!! |
Co-authored-by: Gareth Sylvester-Bradley <31761158+garethsb@users.noreply.github.com>
Co-authored-by: Gareth Sylvester-Bradley <31761158+garethsb@users.noreply.github.com>
Co-authored-by: Gareth Sylvester-Bradley <31761158+garethsb@users.noreply.github.com>
Co-authored-by: Gareth Sylvester-Bradley <31761158+garethsb@users.noreply.github.com>
client_id must be provided when fetching token (/token endpoint). scope checks in a common function.
…ting the static achemas
…eclarations in this file should be @AUTH_API with no space.
…ll be used in the Auth.py
…horize` and `/token` mock auth endpoints
There was a problem hiding this comment.
@lo-simon I think it's as simple as these suggestions to change the mock Auth endpoints to non-standard ones, right?
We might also want to consider a test case involving an issuer with a URL path component, e.g. https://mocks.testsuite.nmos.tv:{port}/testpath, so that we check that they go to the right well-known URL, i.e. https://mocks.testsuite.nmos.tv:{port}/.well-known/oauth-authorization-server/testpath ? Now added as #762.
76c5f79 to
4e232d3
Compare
garethsb
left a comment
There was a problem hiding this comment.
We remember docs needed updating. Now done. Ready to merge!
Add authorization test for checking Node and Registry behavior while receiving missing public key token.