Courtesy of Eva: Add µm support for .top, .stp files#145
Hidden character warning
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #145 +/- ##
==========================================
+ Coverage 74.62% 79.84% +5.21%
==========================================
Files 8 12 +4
Lines 607 928 +321
==========================================
+ Hits 453 741 +288
- Misses 154 187 +33 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
The lines added aren't tested but the code is direct from Eva. What do you think, @ns-rse? I could mock it potentially. But it would simply be a test testing if python successfully multiplies a value by 1000. Alternatively I could ask for the files that need loading. Would the repo size increase be worth the lines being tested? |
There was a problem hiding this comment.
Simple and straight-forward (I had to think about the regex before understanding the grouping).
Perhaps merge and then address tests as a separate issue/pull-request using mocking as you say to set things up? 🤔
Aside : The test wouldn't really be whether Python *1000 rather it would show that our regex and the logic associated with the results are correct by doing the multiplication.
As a further aside have you seen how large the TopoStats repository and its associated history is when cloning? I might if I ever get time try and work out how to remove some of the larger files from the history.
d14289a to
5d897ee
Compare
|
Eva has sent me example files that use um units, I'll add test cases for these 👍 |
|
Have you had an opportunity to add the sample files to the test suite @SylviaWhittle ? |
|
Absolutely no pressure but once this is merged I think a new |
Forgot about this PR. Done! |
Adds a check during
.stpand.toploading to see if the units areµmornmand multiplies the real size by 1000 if so.This is needed for @EvaMartinC to load some AFM images.