tests(topostats): Compare versions as strings#136
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #136 +/- ##
==========================================
+ Coverage 74.62% 76.88% +2.25%
==========================================
Files 8 10 +2
Lines 607 783 +176
==========================================
+ Hits 453 602 +149
- Misses 154 181 +27 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Compares versions of `.topostats` as strings with a view to moving to storing the version of TopoStats that `.topostats` files were created in as a field in the HDF5 `.topostats` file itself. Strings seem to be compared logically... ```python In [1]import topostats In [2]: topostats.__release__ Out[2]: '2.3.2' In [3]: topostats.__release__ > "0.2" Out[3]: True In [4]: "0.2.1" > "0.2" Out[4]: True In [5]: "0.2.0" >= "0.2" Out[5]: True ```
efc9086 to
cf2928b
Compare
4 tasks
SylviaWhittle
approved these changes
Apr 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Compares versions of
.topostatsas strings with a view to moving to storing the version of TopoStats that.topostatsfiles were created in as a field in the HDF5.topostatsfile itself.Strings seem to be compared logically...