Merged
Conversation
…derollins/AFMReader into derollins/verticallyflipped_jpk
…derollins/AFMReader into derollins/verticallyflipped_jpk
Member
Author
ns-rse
reviewed
Mar 27, 2025
ns-rse
reviewed
Mar 27, 2025
ns-rse
reviewed
Mar 27, 2025
Co-authored-by: Neil Shephard <n.shephard@sheffield.ac.uk>
Co-authored-by: Neil Shephard <n.shephard@sheffield.ac.uk>
Co-authored-by: Neil Shephard <n.shephard@sheffield.ac.uk>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #129 +/- ##
==========================================
+ Coverage 74.62% 75.41% +0.78%
==========================================
Files 8 9 +1
Lines 607 720 +113
==========================================
+ Hits 453 543 +90
- Misses 154 177 +23 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
ns-rse
approved these changes
Apr 2, 2025
Collaborator
ns-rse
left a comment
There was a problem hiding this comment.
Thanks @derollins for the PR.
I've one very minor suggestion which I should be able to merge directly here to save the need for you to change and push.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

As described in issue #126 JPK images are vertically reflected and need to be flipped to correct. This pull request adds the ability of the
load_jpk()function to do this correction, with the optionflip_imageadded to set this option.Additionally, I added error handling to the reading of the TIFF tags but, this made
_get_z_scaling()too complicated for pre-commit, so I separated out the tag value reading to another function.I also corrected a typo in the examples notebook.