tests: FileNotFound consistently raised & tested#110
Merged
Conversation
SylviaWhittle
approved these changes
Feb 3, 2025
Collaborator
SylviaWhittle
left a comment
SylviaWhittle
left a comment
There was a problem hiding this comment.
<disclosure: not tested locally but read all the lines, don't see how it could go wrong given those tests that have been added and pass>
Looks good! Thank you 🙏
Collaborator
|
(I assume the |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #110 +/- ##
==========================================
+ Coverage 65.87% 74.62% +8.75%
==========================================
Files 3 8 +5
Lines 337 607 +270
==========================================
+ Hits 222 453 +231
- Misses 115 154 +39 ☔ View full report in Codecov by Sentry. |
Closes #80 - Ensures `FileNotFound` error is consistently raised across modules. - Adds a test for each module that `FileNotFound` error is raised. - Standardises importing of module rather than functions across all tests. - Adds the `--unsafe` argument to `check_yaml` pre-commit hook so it doesn't complain about `mkdocs.yaml`.
ns-rse
force-pushed
the
ns-rse/80-file-not-found
branch
from
c12bb94 to
ac9753c
Compare
Collaborator
Author
No, but I know how to solve that having just done so on TopoStats so will squeeze it into this PR, good spot, thanks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #80
FileNotFounderror is consistently raised across modules.FileNotFounderror is raised.