Allow onReceive to be overridden.#15
Open
erikogenvik wants to merge 1 commit into50ButtonsEach:masterfrom
Open
Allow onReceive to be overridden.#15erikogenvik wants to merge 1 commit into50ButtonsEach:masterfrom
erikogenvik wants to merge 1 commit into50ButtonsEach:masterfrom
Conversation
The main cause for this is that FlicManager.getInstance can throw a couple of runtime exceptions, amongst them AppCredentialsNotProvidedException and FlicAppNotInstalledException which if not caught will crash the app. This allows the concrete broadcast to catch and process these exceptions, without crashing the app.
|
I get the same error when implenting the broadcast receiver. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The main cause for this is that FlicManager.getInstance can
throw a couple of runtime exceptions, amongst them
AppCredentialsNotProvidedException and FlicAppNotInstalledException
which if not caught will crash the app.
This allows the concrete broadcast to catch and process these exceptions,
without crashing the app.
(Another option would be to handle the exceptions in the FlicLib. But for our project we actually want to handle the exceptions ourselves.)
In general a more preferred option would be to not provide this as a class inheriting from BroadcastReceiver but instead provide a BroadcastHandler class, which accepted a callback interface.