634 double encoding breaks query params

github4s/src/main/scala/github4s/interpreters/IssuesInterpreter.scala

@@ -16,7 +16,6 @@
 
 package github4s.interpreters
 
-import java.net.URLEncoder.encode
 import java.time.ZonedDateTime
 
 import cats.syntax.all._
@@ -55,7 +54,7 @@ class IssuesInterpreter[F[_]](implicit client: HttpClient[F]) extends Issues[F]
     client.get[SearchIssuesResult](
       method = "search/issues",
       headers = headers,
-      params = Map("q" -> s"${encode(query, "utf-8")}+${searchParams.map(_.value).mkString("+")}"),
+      params = Map("q" -> s"$query+${searchParams.map(_.value).mkString("+")}"),
       pagination
     )
 

github4s/src/main/scala/github4s/interpreters/RepositoriesInterpreter.scala

@@ -16,8 +16,6 @@
 
 package github4s.interpreters
 
-import java.net.URLEncoder.encode
-
 import cats.Functor
 import cats.data.NonEmptyList
 import cats.syntax.functor._
@@ -74,7 +72,7 @@ class RepositoriesInterpreter[F[_]: Functor](implicit
     client.get[SearchReposResult](
       "search/repositories",
       headers,
-      params = Map("q" -> s"${encode(query, "utf-8")}+${searchParams.map(_.value).mkString("+")}"),
+      params = Map("q" -> s"$query+${searchParams.map(_.value).mkString("+")}"),
       pagination
     )
 

github4s/src/test/resources/logback.xml

@@ -12,4 +12,4 @@
             <AppenderRef ref="Console"/>
         </Root>
     </Loggers>
-</Configuration>
+</Configuration>

github4s/src/test/scala/github4s/integration/ReposSpec.scala

@@ -471,6 +471,23 @@ trait ReposSpec extends BaseIntegrationSpec {
     response.statusCode shouldBe okStatusCode
   }
 
+  it should "successfully return results when a valid repo is provided using <owner>/<name> syntax" taggedAs Integration in {
+    val response = clientResource
+      .use { client =>
+        Github[IO](client, accessToken).repos
+          .searchRepos(s"$validRepoOwner/$validRepoName", Nil)
+      }
+      .unsafeRunSync()
+
+    testIsRight[SearchReposResult](
+      response,
+      { r =>
+        r.total_count > 0 shouldBe true
+        r.items.nonEmpty shouldBe true
+      }
+    )
+  }
+
   it should "return an empty result for a non existent query string" taggedAs Integration in {
     val response = clientResource
       .use { client =>

github4s/src/test/scala/github4s/unit/ReposSpec.scala

@@ -425,7 +425,7 @@ class ReposSpec extends BaseSpec {
   "Repos.searchRepos" should "call httpClient.get with the right parameters" in {
 
     implicit val httpClientMock: HttpClient[IO] = httpClientMockGet[SearchReposResult](
-      url = "search/repositories",
+      url = githubApiUrl,
       params = Map("q" -> s"+${validSearchParams.map(_.value).mkString("+")}"),
       response = IO.pure(searchReposResult)
     )

github4s/src/test/scala/github4s/utils/TestData.scala

@@ -33,7 +33,7 @@ trait TestData {
   val invalidUsername = "GHInvalidUserName"
   val invalidPassword = "invalidPassword"
 
-  val githubApiUrl                           = "http://api.github.com"
+  val githubApiUrl                           = "https://api.github.com"
   val user                                   = User(1, validUsername, githubApiUrl, githubApiUrl)
   val userRepoPermission: UserRepoPermission = UserRepoPermission("admin", user)
 
@@ -89,7 +89,7 @@ trait TestData {
 
   val validFileContent = "def hack(target: String): Option[Int] = None"
 
-  val validSearchQuery       = "Scala 2.12"
+  val validSearchQuery       = "\"/\" not accepted in SearchRepos"
   val nonExistentSearchQuery = "nonExistentSearchQueryString"
   val validSearchParams = List(
     OwnerParamInRepository(s"$validRepoOwner/$validRepoName")