Hotfix/set-slope-angle-before-collapse

[zacczakk]

Summary by CodeRabbit

• Bug Fixes

  • Adjusted calculation sequence for touchdown attributes so tc now derives from the updated phi value, improving numerical correctness and consistency.

• Documentation

  • Updated user-facing references to release v2.6.3 in the demo notebook and documentation to reflect the latest guidance.

• Chores

  • Bumped package version to 2.6.3 and aligned related versioning configuration.

[coderabbitai]

Walkthrough

Project version references updated to 2.6.3 across metadata, docs, and a demo notebook. In weac/mixins.py, the call order in set_touchdown_attributes was changed to set phi before computing tc.

Changes

Cohort / File(s)	Summary of Changes
Version bump metadata CITATION.cff, pyproject.toml, weac/__init__.py, docs/sphinx/conf.py, demo/demo.ipynb	Updated version references to 2.6.3; adjusted bumpversion search/replace patterns to double quotes; notebook text updated to reference v2.6.3.
Touchdown attribute flow weac/mixins.py	Reordered calls in set_touchdown_attributes: set_phi(phi) now precedes set_tc(cf) so tc uses the updated phi via calc_qn.

Sequence Diagram(s)

sequenceDiagram
  participant Caller
  participant Mixin as set_touchdown_attributes
  participant Phi as set_phi
  participant Qn as calc_qn
  participant Tc as set_tc

  Caller->>Mixin: set_touchdown_attributes(phi, cf)
  Mixin->>Phi: set_phi(phi)
  Phi-->>Mixin: phi updated
  Mixin->>Qn: calc_qn() using updated phi
  Qn-->>Mixin: qn
  Mixin->>Tc: set_tc(cf) (tc computed with updated phi/qn)
  Tc-->>Caller: done

Loading

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Possibly related PRs

• fix: Set slope angle before collapse height #12: Reorders set_phi before set_tc in set_touchdown_attributes, matching this control flow change.
• Bump version: 2.6.1 → 2.6.2 #11: Performs the same 2.6.3 version bump across metadata and docs.

Tip

🔌 Remote MCP (Model Context Protocol) integration is now available!

Pro plan users can now connect to remote MCP servers from the Integrations page. Connect with popular remote MCPs such as Notion and Linear to add more context to your reviews and chats.

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: ASSERTIVE
Plan: Pro

💡 Knowledge Base configuration:

• MCP integration is disabled by default for public repositories
• Jira integration is disabled by default for public repositories
• Linear integration is disabled by default for public repositories

You can enable these settings in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 28b6ad7 and b858193.

📒 Files selected for processing (6)

• CITATION.cff (1 hunks)
• demo/demo.ipynb (1 hunks)
• docs/sphinx/conf.py (1 hunks)
• pyproject.toml (3 hunks)
• weac/__init__.py (1 hunks)
• weac/mixins.py (1 hunks)

👮 Files not reviewed due to content moderation or server errors (1)

• demo/demo.ipynb

🔇 Additional comments (5)

weac/__init__.py (1)

14-14: Version bump aligned with release.

__version__ correctly set to 2.6.3 and consistent with other metadata updates in the PR.

CITATION.cff (1)

11-11: Citation metadata already current—confirm DOI

• The date-released: 2021-12-30 matches the v2.6.3 release date in the CITATION.cff.
• I don’t see an explicit DOI for v2.6.3 under identifiers. If you’ve archived this release on Zenodo (or a similar service), you can add:

  identifiers:
    - description: "Release v2.6.3: [brief summary of changes]"
      type: doi
      value: <YOUR-DOI-HERE>

Would you like me to draft a minimal patch to insert that DOI entry?

docs/sphinx/conf.py (1)

13-13: Docs release synchronized.

The Sphinx release string is correctly updated to 2.6.3 to match the package version.

weac/mixins.py (1)

779-785: Correct call order: setting phi before tc fixes stale-angle-dependent tc.

Calling set_phi(phi) before set_tc(cf) ensures calc_qn() uses the correct slope angle when computing tc. This addresses the touchdown collapse dependence on slope.

pyproject.toml (1)

7-7: Version bump and bumpversion templates look consistent.

• Project version set to 2.6.3.
• [tool.bumpversion] current_version updated to 2.6.3.
• Search/replace templates switched to double quotes and match the lines in weac/__init__.py and docs/sphinx/conf.py.

No issues found.

Also applies to: 80-80, 92-93, 100-101

✨ Finishing Touches

• 📝 Generate Docstrings

🧪 Generate unit tests

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch hotfix/set-slope-angle-before-collapse

---

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR/Issue comments)

Type @coderabbitai help to get the list of available commands.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Status, Documentation and Community

• Visit our Status Page to check the current availability of CodeRabbit.
• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[cursor]

🚨 Bugbot Trial Expired

Your Bugbot trial has expired. Please purchase a license in the Cursor dashboard to continue using Bugbot.

[Copilot]

Pull Request Overview

This hotfix addresses an issue with the order of method calls in the set_touchdown_attributes function. The primary change swaps the order of set_tc(cf) and set_phi(phi) calls, ensuring that the slope angle is set before any potential collapse calculations that may depend on it.

• Reordered method calls in set_touchdown_attributes to set phi before tc
• Updated version number from 2.6.2 to 2.6.3 across all configuration files
• Updated quote styles in bumpversion configuration for consistency

Reviewed Changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.

Show a summary per file

File	Description
weac/mixins.py	Swapped order of set_phi() and set_tc() calls in touchdown attributes setup
weac/init.py	Updated package version to 2.6.3
pyproject.toml	Updated version and standardized quote styles in bumpversion config
docs/sphinx/conf.py	Updated documentation release version to 2.6.3
demo/demo.ipynb	Updated notebook reference to version 2.6.3
CITATION.cff	Updated citation version to 2.6.3

---

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
You can also share your feedback on Copilot code review for a chance to win a $100 gift card. Take the survey.}

[Copilot]

Version mismatch detected: init.py shows version 2.6.3 but pyproject.toml was updated from 2.6.2 to 2.6.3, suggesting init.py should have been updated from 2.6.1 to 2.6.3. This inconsistency could cause version conflicts.