Skip to content

fix: make CI portable across runner defaults - #1

Merged
harperreed merged 4 commits into
mainfrom
wip/fix-ci-portability
Aug 27, 2026
Merged

harperreed merged 4 commits into
mainfrom
wip/fix-ci-portability

Conversation

@harperreed

@harperreed harperreed commented Aug 27, 2026 •

Copy link
Copy Markdown
Member

Fixes the two failures from the first main-branch CI run.

  • install the documented mise wrapper in the Test job
  • make real-PTY text assertions choose plain output explicitly
  • record the CI environment trap and repair evidence

Verification:

  • uncached canonical gate with GOROOT and NO_COLOR removed
  • independent task reviews and whole-branch review with zero findings

View with [code]smith Autofix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need. Autofix is disabled.

Summary by CodeRabbit

  • Bug Fixes

    • Standardized pseudo-terminal setup output to exclude color codes, improving test consistency across environments.
  • CI

    • Added mise environment setup to the test workflow for more portable and reliable continuous integration runs.
  • Documentation

    • Documented color-related testing requirements and added design and implementation planning for CI portability improvements.

@coderabbitai

coderabbitai Bot commented Aug 27, 2026 •

Copy link
Copy Markdown

Review Change Stack

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: c2950e3f-621b-4150-8e8f-a7d52f18ee9a

📥 Commits

Reviewing files that changed from the base of the PR and between e16d39c and 1f96e2c.

📒 Files selected for processing (5)
  • .github/workflows/ci.yml
  • docs/superpowers/plans/2026-08-26-ci-portability.md
  • docs/superpowers/specs/2026-08-26-ci-portability-design.md
  • gotchas.md
  • tests/e2e/setup_test.go

Walkthrough

The PR adds mise setup to the CI test job and makes real-PTY setup output deterministic by passing --color never. It also adds design, implementation, verification, and troubleshooting documentation for the portability repairs.

Changes

CI portability

Layer / File(s) Summary
Portability design and verification scope
docs/superpowers/specs/..., docs/superpowers/plans/...
The design and plan document the missing mise dependency, PTY color behavior, repair steps, verification commands, and non-goals.
Deterministic PTY output
tests/e2e/setup_test.go, gotchas.md, docs/superpowers/plans/...
runSetupPTY passes --color never. The documentation records the NO_COLOR environment issue and related verification workflow.
CI mise setup
.github/workflows/ci.yml, docs/superpowers/plans/...
The test job runs jdx/mise-action@v4 with install: false before dependency download. The plan records the missing-command failure and validation steps.

Estimated code review effort: 2 (Simple) | ~10 minutes

Poem

A rabbit checks the runner bright

Mise now hops into the test job right
PTY colors fade from view
Plain transcripts make contracts true
CI carrots pass the night

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch wip/fix-ci-portability

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@harperreed
harperreed marked this pull request as ready for review August 27, 2026 03:51
@harperreed
harperreed merged commit 1f96e2c into main Aug 27, 2026
5 of 6 checks passed
@harperreed
harperreed deleted the wip/fix-ci-portability branch August 27, 2026 03:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant