Skip to content

pr-agent: a bot comment no longer cancels a review - #63

Merged
bong-water-water-bong merged 1 commit into
mainfrom
pr-agent-concurrency
Sep 25, 2026
Merged

bong-water-water-bong merged 1 commit into
mainfrom
pr-agent-concurrency

Conversation

@bong-water-water-bong

Copy link
Copy Markdown
Collaborator

On #62, the Docs7 bot's comment started an issue_comment run. Its job was skipped, but the workflow-level concurrency group still cancelled the running review (run 36114466708).

Concurrency now sits on the job, so only runs that actually execute take the group.

🤖 Generated with Claude Code

…el a review

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@github-actions

Copy link
Copy Markdown

PR Reviewer Guide 🔍

Here are some key observations to aid the review process:

🎫 Ticket compliance analysis 🔶

62 - Partially compliant

Compliant requirements:

  • Fix for NPU lane idle timeout issue implemented
  • Hardware context now created per generate() call
  • Context dropped at end of generate() and on exception paths
  • Performance measurements and verification provided
  • Documentation update noted in ticket description

Non-compliant requirements:

  • The follow-up items about npu-draft bench and 35B path not addressed in this PR

Requires further human verification:

  • Verification of performance claims on actual hardware
  • Confirmation that xrt-smi shows no hardware contexts after fix
⏱️ Estimated effort to review: 2 🔵🔵⚪⚪⚪
🧪 No relevant tests
🔒 No security concerns identified
⚡ Recommended focus areas for review

Concurrency Configuration Change

The concurrency configuration has been moved from the workflow level to the job level in the GitHub Actions workflow. This change ensures that only jobs that actually execute will cancel other in-progress runs in the same concurrency group, rather than comments that skip jobs (like bot comments) cancelling the entire review run. This is a good change for workflow reliability.

# on the job, not the workflow: a comment that skips the job (a bot's, say) must not cancel a review
concurrency:
  group: pr-agent-${{ github.event.pull_request.number || github.event.issue.number }}
  cancel-in-progress: true

@bong-water-water-bong
bong-water-water-bong merged commit 2bef592 into main Sep 25, 2026
3 checks passed
@bong-water-water-bong
bong-water-water-bong deleted the pr-agent-concurrency branch September 25, 2026 08:47
bong-water-water-bong added a commit that referenced this pull request Oct 2, 2026
…gram cache cap; serve runs PQ2_0/PTQ1_0 files on HRX (#280)

llama.cpp fork since bd5b297:
- #62: PrismML's PQ2_0 / PTQ1_0 as native ggml types (142 / 143) with HRX decode on the K-quant
  kernels; Q1_0 decode moves onto them. Ternary-Bonsai-2-27B (balanced mode, llama-bench -fa 1):
  PTQ1_0 5.53 GiB 14.3 tok/s, PQ2_0 6.70 GiB 15.8 tok/s, vs 14.13 GiB / 15.3 for the Q4_0 copy;
  KLD vs CPU 0.000129 for all three. CPU decode bit-identical to PrismML's build on every tensor of
  both 27B files. test-backend-ops -b HRX0 1020/1020.
- #63: GGML_HRX_GRAPH_PROGRAM_CACHE (default 64) bounds HRX server memory: ZAYA1-8B over 40
  varying-length requests peaks at 8.7 GiB instead of growing past 24.6 GiB; answers identical.

serve: a file in PrismML's ternary types goes to HRX with --device auto, rotated (prism.hadamard)
or not (Ternary-Bonsai-1.7B); another --device is refused with the converter's name. Smoke test on
strixhalo: `1bit serve -m Ternary-Bonsai-2-27B-PTQ1_0.gguf` routed to HRX and answered "Paris" 3/3.
tests/prism_route.sh covers the new routes; ctest 19/19 (build without HRX).

Docs: docs/hrx.md Ternary Bonsai section (native types, table), the cache cap section, "Our patches".
Registry regenerated (no mapping changes).

Co-authored-by: bong-water-water-bong <bong-water-water-bong@1bit.gg>
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant