Skip to content

Document verified HRX MLA decode accuracy - #341

Merged
bong-water-water-bong merged 2 commits into
mainfrom
copilot/fix-hrx-mla-decode-accuracy
Oct 6, 2026
Merged

bong-water-water-bong merged 2 commits into
mainfrom
copilot/fix-hrx-mla-decode-accuracy

Conversation

Copilot AI commented Oct 6, 2026 •

Copy link
Copy Markdown
Contributor

The reported GLM-4.7-Flash MLA decode degradation past 512 KV cells is not reproducible on the current pin; masked-V nondeterminism is addressed by the pinned flash-attention fix.

  • Current measurements: Document HRX (-ub 1) and CPU perplexity at 4096 and 8192 tokens, including the CPU reference caveats.
  • Scope: Link the pinned MLA strided-V and masked-V fixes; note that the historical A/B and op-level drift bisect remain unverified.

Co-authored-by: bong-water-water-bong <277547417+bong-water-water-bong@users.noreply.github.com>
Copilot AI changed the title [WIP] Fix HRX MLA decode path accuracy issue past 512 KV cells Document verified HRX MLA decode accuracy Oct 6, 2026
@github-actions

github-actions Bot commented Oct 6, 2026

Copy link
Copy Markdown

PR Reviewer Guide 🔍

Here are some key observations to aid the review process:

🎫 Ticket compliance analysis 🔶

310 - Partially compliant

Compliant requirements:

  • Document that the reported GLM-4.7-Flash MLA decode degradation is not reproducible on the current pin
  • Link the pinned MLA strided-V and masked-V fixes
  • Include current measurements of HRX and CPU perplexity at 4096 and 8192 tokens
  • Note that the historical A/B and op-level drift bisect remain unverified
  • Address the masked-V nondeterminism issue

Non-compliant requirements:

  • None

Requires further human verification:

  • None
⏱️ Estimated effort to review: 2 🔵🔵⚪⚪⚪
🧪 No relevant tests
🔒 No security concerns identified
⚡ Recommended focus areas for review

Documentation Clarity

The documentation states that the historical 11.79 and 10.64 results do not have a runnable old-path A/B build, so the op-level drift bisect remains unverified. This is a significant limitation in the documentation as it leaves the root cause of the issue unresolved and unverified. The documentation should either provide a clear explanation of why the bisect cannot be performed or suggest a way to perform it in the future.

invalid for this model. The historical 11.79 and 10.64 results do not have a runnable
old-path A/B build, so the op-level drift bisect remains unverified. The masked-V kernel

@bong-water-water-bong
bong-water-water-bong marked this pull request as ready for review October 6, 2026 22:31
@bong-water-water-bong
bong-water-water-bong merged commit 56624cb into main Oct 6, 2026
7 checks passed
@bong-water-water-bong
bong-water-water-bong deleted the copilot/fix-hrx-mla-decode-accuracy branch October 6, 2026 22:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

HRX MLA decode path loses accuracy past ~512 KV cells (GLM-4.7-Flash, deepseek2)

2 participants