Repository navigation
Embed the engine into Lemonade, not Lemonade into the engine: drop the vendored Lemonade - #22
Merged
Merged
Conversation
…e vendored Lemonade Following geramyL's review. The engine is a backend Lemonade launches; it exposes only an OpenAI-compatible API (1bit serve). - third_party/lemonade (v11.9.0, ~900 files) and its local deltas (onebit, mlx and zinc recipes, hrx_device, embed patch) are removed, as are `1bit lemonade` and its Lemonade-specific tests. `1bit` now builds from 3 steps instead of ~290. - json v3.11.3 and cpp-httplib v0.47.0 are pinned by the engine itself (the same commits as before). - 1bit serve --device mlx keeps MLX on Apple Silicon (the former local mlx recipe's launch contract: lemon-mlx-server <hf id> --port). - Portable child spawn: fork + PR_SET_PDEATHSIG on Linux, posix_spawnp elsewhere; model ids keep dots except a .gguf extension. - tests/smoke_serve.sh + tests/fake_backend.py: serve's proxy in CI without a GPU (health, models, rename, SSE relay, no orphan after SIGKILL). - Docs: lemonade.md (the new relationship and how it got here), serve.md, apple.md, hrx.md, npu.md, zinc.md, kernel.md, PORTING step 1 and diagram, README intro/status/thank-you, NOTICE (Lemonade and its fetched libraries removed; json and httplib now fetched by us), bump-hrx.yml. Verified: ryzen (no NPU) builds and ctest passes (smoke_serve, npu_full_elf_md5); Strix Halo NPU build: ctest passes and serve_e2e passes on npu, vulkan, hrx and zinc. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
bong-water-water-bong
force-pushed
the
drop-embedded-lemonade
branch
from
September 23, 2026 22:52
8d6a1ef to
da3a50c
Compare
bong-water-water-bong
enabled auto-merge (squash)
September 23, 2026 22:53
This was referenced Oct 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #21 (
1bit serve). This follows geramyL's review: the engine is a backend Lemonade launches and exposes only an OpenAI-compatible API.Removed
third_party/lemonade: Lemonade v11.9.0, about 900 files, plus our local deltas (the onebit, mlx and zinc recipes,hrx_device, the embed patch).1bit lemonade, and the Lemonade-specific tests:smoke_lemonadeand the hrx, zinc and mlx lemonade e2e tests.1bitnow builds in 3 steps instead of about 290.Kept, or moved into
1bit serve--device mlxfor Apple Silicon. It uses the old mlx recipe's launch contract, so MLX isn't lost.PR_SET_PDEATHSIGon Linux andposix_spawnpelsewhere, so the engine still builds on macOS.New
tests/smoke_serve.sh+tests/fake_backend.pytestserve's proxy in CI, without a GPU: health, models, the reply rename, SSE relay, and no orphaned backend after SIGKILL.Docs
lemonade.mdnow describes the new relationship and how it got here. Also updated: serve, apple, hrx, npu, zinc and kernel docs, PORTING step 1 and its diagram, the README intro, status and thank-you (Lemonade is thanked as the engine's home),NOTICE(Lemonade and its fetched libraries removed; json and httplib listed as ours), andbump-hrx.yml.Verified
smoke_serve,npu_full_elf_md5).serve_e2epasses on npu, vulkan, hrx and zinc.--device mlxon the Mac. The launch contract is unchanged from the verified recipe; ctestserve_e2e_mlxis ready for it.Next: the upstream Lemonade recipe PR that launches
1bit serve. It goes to AMD's repo, so the draft comes to you first.🤖 Generated with Claude Code