…x (engine#115)
Was 1e775cd, needed to move to include both the ZAYA1-VL work already on
main (f30cc43, via #149) and the multi-pass decode-split reduction from
llama.cpp#13 that #121 was trying to add - #121 conflicted because its
target commit predated #149's pin advance. This points at the current
1bit/hrx-vulkan-patched tip (8dd75eb), a strict superset of both.
Verified: onebit builds; the exact >2048-token needle-retrieval repro from
engine#115 is correct and deterministic (4 back-to-back runs at 2124 and
3599 tokens, cache_prompt:false). The known residual fault (engine#123) is
real and reproduces more readily here than llama.cpp#13's own report
(0/5 there; 4/4 here across two separate runs, isolated to depths >2048,
Vulkan0 and short-context HRX0 unaffected) - noted on #123 for whoever
picks up the follow-up fix.
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Supersedes #121, which conflicted with main after #149 (ZAYA1-VL) advanced the same submodule pointer past where #121's target commit (
f59f6d37a, the pre-merge tip of llama.cpp#13) was cut. This points at the current1bit/hrx-vulkan-patchedtip (8dd75eb), which is a strict superset of both #149's pin and llama.cpp#13's multipass fix - verified withgit merge-base --is-ancestorfor both.Closes the remaining half of #115, same as #121 intended:
onebitbuilds, and the exact >2048-token needle-retrieval repro is correct and deterministic (ran 4 times across two depths - 2124 and 3599 tokens - identical4-8-1-5-9-2each time,cache_prompt:false).Re: the known residual fault (#123). llama.cpp#13 reported 0/5 GPU faults at depth 2100 in its own testing. Re-running the same
llama-bench -p 0 -n 8 -d 2100here faulted 4 times out of 4 attempts (HSA_STATUS_ERROR_MEMORY_FAULT,failed to decode generation batch, res = -3) - both as part of a combined-d 2100,3000run and in three isolated repeats at 2100 alone. Confirmed this isn't a broader GPU/driver problem:Vulkan0on the same box ran cleanly immediately before and after, and HRX0 at a short depth (500, below the multipass threshold) also ran clean. So the fault is real, reproduces consistently in this environment specifically at depths just above 2048, and is worse here than llama.cpp#13's own measurement - not the rare edge case the 1/5-at-d3000 number suggested. Posting this to #123 as well so the follow-up fix has accurate reproduction data.Merging per explicit direction: the multi-pass fix's benefit (removing the 32% decode cliff and un-capping context past 2048) is worth taking now with the fault open, tracked as a known issue to fix next.
🤖 Generated with Claude Code