Repository navigation
Remove CLI hash verification and path allowlist - #15
Merged
Merged
Conversation
These features (v0.1.11+) are not present in the Python reference SDK and added a hard dependency on OpenSSL (Linux/macOS) / crypt32 (Windows) for questionable benefit — the hash was validated against a user-supplied value with no trust anchor. Removed: - cli_verification.cpp/.hpp (SHA-256 compute, hash verify, path allowlist) - allowed_cli_paths and cli_hash_sha256 fields from ClaudeOptions - Crypto library linking from CMakeLists.txt - Verification calls from both subprocess transport implementations
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Details
The hash check validated against a user-supplied value with no trust anchor (no official hash distribution channel), providing questionable security benefit while adding a platform-specific crypto dependency.
Files removed
src/internal/transport/cli_verification.cppsrc/internal/transport/cli_verification.hppFields removed from
ClaudeOptionsallowed_cli_pathscli_hash_sha256Test plan