feat: midenup init now saves the miden symlink in $CARGO_HOME/bin - #166
Merged
Conversation
Signed-off-by: Tomas Fabrizio Orsi <tomas.orsi@lambdaclass.com>
lima-limon-inc
added
command:miden
bitwalker
approved these changes
Mar 10, 2026
bitwalker
left a comment
bitwalker
left a comment
Collaborator
There was a problem hiding this comment.
I'm signing off on this, but one thing I'm unsure about is whether Cargo may prune the directory of things it doesn't think it installed (or perceives as being orphaned in some way, since Cargo assumes that things in this directory are managed by cargo install or rustup). I don't know if it actually does this, but something we may have to anticipate. We might be alright here when the symlink points to a Cargo-installed midenup binary though.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #161
In order to reduce manual intervention with
midenup(for situations like github actions), nowmidenup initsaves themidensymlink in cargo'sbindirectory.