✨ Improve site quality and content trust#53
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request refactors several UI components and content logic, notably replacing the Leaflet-based map in the Location card with a static CSS design and enhancing the Posts card with descriptions and tags. It also introduces a shouldPublishPost utility to manage content visibility and updates workout display logic for zero-distance activities. Feedback identifies two issues with Tailwind CSS syntax: the bg-size- utility in Location.astro and the supports-backdrop-filter modifier in ThoughtsCanvasBottomToolbar.astro are likely invalid and should be updated to use standard bracket notation.
📸 Screenshots for PR #53
PR screenshots folder (branch |
- Add post descriptions and tag badges to card listings - Improve accessibility with prefers-reduced-motion support - Make LightBox conditional for better performance - Fix typos and add JSON API example to posts - Handle zero-distance indoor activities in workouts
yuler
force-pushed
the
optimize-whole-website
branch
from
5de296a to
532fc3d
Compare
Move 2024 posts from 2025 directory to 2024, and remove explicit slug fields since they're now inferred from filenames.
|
/gemini review |
There was a problem hiding this comment.
Code Review
This pull request introduces several UI and documentation enhancements, including a new deployment section in AGENTS.md, support for prefers-reduced-motion in the signature component, and improved metadata display for posts and workouts. The workout display logic was refined to handle zero-distance activities, and the LightBox component is now conditionally rendered based on content. Review feedback recommends implementing defensive null checks for post tags and correcting grammatical errors in the DeepSeek article's code examples.
Co-authored-by: Cursor <cursoragent@cursor.com>
- Introduce a new AgentStuff component to display design guidelines and agent instructions. - Adjust Thoughts component layout for improved spacing and responsiveness.
Add Bot and Sparkles icons as background elements to the AgentStuff component for visual enhancement.
|
/gemini review |
There was a problem hiding this comment.
Code Review
This pull request refactors the homepage layout using CSS grid for improved responsive ordering and introduces several UI enhancements, including a new AgentStuff card and enriched post and thought previews. It also adds support for prefers-reduced-motion in the signature animation and updates workout display logic to correctly handle zero-distance indoor activities. Feedback focuses on improving text readability by replacing break-all with break-words in the AgentStuff component and increasing the font size of post tags to align with project typography standards.
| {post.data.tags && post.data.tags.length > 0 && ( | ||
| <div class="mt-2 flex flex-wrap gap-1.5"> | ||
| {post.data.tags.slice(0, 3).map(tag => ( | ||
| <span class="border border-gray-200 px-1.5 py-0.5 text-[10px] leading-none text-gray-500"> |
There was a problem hiding this comment.
The font size 10px is below the smallest defined typography token in the design guide (mono-label at 0.75rem or 12px). This can make the tags difficult to read, especially on high-resolution screens. Consider using text-xs to align with the project's typography standards and improve legibility.
<span class="border border-gray-200 px-1.5 py-0.5 text-xs leading-none text-gray-500">
1 participant
Summary
Test plan
Made with Cursor