From 0e7ed5c5046664c0a6445d5d2de66ace91fcb08c Mon Sep 17 00:00:00 2001
From: Thomas Wirth <thomas@wtho.de>
Date: Fri, 6 Aug 2021 22:18:27 +0200
Subject: [PATCH] fix(webapp): assess empty message with comments

---
 commit-editor-app/src/components/validity-indicator.vue | 3 ++-
 commit-editor-app/src/lib/message-empty-check.ts        | 9 +++++++++
 2 files changed, 11 insertions(+), 1 deletion(-)
 create mode 100644 commit-editor-app/src/lib/message-empty-check.ts

diff --git a/commit-editor-app/src/components/validity-indicator.vue b/commit-editor-app/src/components/validity-indicator.vue
index e93e051..a2f6c2b 100644
--- a/commit-editor-app/src/components/validity-indicator.vue
+++ b/commit-editor-app/src/components/validity-indicator.vue
@@ -53,6 +53,7 @@
 <script lang="ts">
 import { computed, defineComponent, inject, ref } from 'vue'
 import { monaco } from '../lib/monaco'
+import { isCommitMessageEmpty } from '../lib/message-empty-check'
 import { TabStore, tabStoreSymbol } from '../stores/tab.store'
 import Icon from './icon.vue'
 import MonacoStyleTooltip from './monaco-style-tooltip.vue'
@@ -82,7 +83,7 @@ export default defineComponent({
         ).length ?? 0
     )
     const hasConfigError = computed(() => tabStore?.state.configErrors.length ?? 0 > 0)
-    const messageEmpty = computed(() => !tabStore?.state.commitMessage)
+    const messageEmpty = computed(() => isCommitMessageEmpty(tabStore?.state.commitMessage || ''))
 
     const clickError = () => tabStore?.messageEditorNextMarkerActionTriggered()
 
diff --git a/commit-editor-app/src/lib/message-empty-check.ts b/commit-editor-app/src/lib/message-empty-check.ts
new file mode 100644
index 0000000..4667872
--- /dev/null
+++ b/commit-editor-app/src/lib/message-empty-check.ts
@@ -0,0 +1,9 @@
+// TODO read comment character from config
+export function isCommitMessageEmpty(
+  message: string,
+  commentCharacter = '#'
+): boolean {
+  return !message
+    .split('\n')
+    .some((line) => !line.startsWith(commentCharacter) && line.trim())
+}