Merge pull request #1219 from weeco/ms/fix-internal-topics-filter

twmb · web-flow · commit e0832fcbdccb · 2026-01-21T12:58:10.000-07:00
kadm: fix ListTopics filtering internal topics when explicitly requested
diff --git a/pkg/kadm/topics.go b/pkg/kadm/topics.go
@@ -26,7 +26,11 @@ func (cl *Client) ListTopics(
 	if err != nil {
 		return nil, err
 	}
-	t.FilterInternal()
+	// Only filter internal topics when listing all topics (no specific topics requested).
+	// If specific topics are named, include them even if they are internal.
+	if len(topics) == 0 {
+		t.FilterInternal()
+	}
 	return t, nil
 }
 

Original file line number	Diff line number	Diff line change
`@@ -26,7 +26,11 @@ func (cl *Client) ListTopics(`
`26`	`26`	`if err != nil {`
`27`	`27`	`return nil, err`
`28`	`28`	`}`
`29`		`- t.FilterInternal()`
	`29`	`+ // Only filter internal topics when listing all topics (no specific topics requested).`
	`30`	`+ // If specific topics are named, include them even if they are internal.`
	`31`	`+ if len(topics) == 0 {`
	`32`	`+ t.FilterInternal()`
	`33`	`+ }`
`30`	`34`	`return t, nil`
`31`	`35`	`}`
`32`	`36`