Add new value for 'forge.display.setStatusBarStyle' on iOS: 'UIStatusBarStyleDarkContent'

Author: antoinevg

inspector/ios-inspector/ForgeModule/display/display_EventListener.m

@@ -41,6 +41,12 @@ + (void)application:(UIApplication *)application postDidFinishLaunchingWithOptio
 		NSString *style = [[[config objectForKey:@"statusbar"] objectForKey:@"ios"] objectForKey:@"style"];
 		if ([style isEqualToString:@"light_content"] || [style isEqualToString:@"UIStatusBarStyleLightContent"]) {
 			ForgeApp.sharedApp.viewController.statusBarStyle = UIStatusBarStyleLightContent;
+		} else if ([style isEqualToString:@"dark_content"] ||[style isEqualToString:@"UIStatusBarStyleDarkContent"]) {
+			if (@available(iOS 13.0, *)) {
+				ForgeApp.sharedApp.viewController.statusBarStyle = UIStatusBarStyleDarkContent;
+			} else {
+				ForgeApp.sharedApp.viewController.statusBarStyle = UIStatusBarStyleDefault;
+			}
 		} else if ([style isEqualToString:@"default"] ||[style isEqualToString:@"UIStatusBarStyleDefault"]) {
 			ForgeApp.sharedApp.viewController.statusBarStyle = UIStatusBarStyleDefault;
 		}

module/docs/index.md

@@ -30,7 +30,7 @@ Transparent
 :   Sets iOS status bar transparency.
 
 Style
-:  Sets the status bar style on iOS, `default` will use black text, `light_content` will use white text.
+:  Sets the status bar style on iOS: `UIStatusBarStyleDefault` will use black text if iOS dark mode is disabled. If dark mode is enabled the text color will be controlled by iOS. `UIStatusBarStyleLightContent` will use light text. `UIStatusBarStyleDarkContent` will use dark text irrespective of iOS dark mode settings.
 
 
 ### Orientations

module/inspector_config.json

@@ -10,7 +10,7 @@
                 },
                 "ios": {
                     "hidden": true,
-                    "transparent": true,
+                    "transparent": false,
                     "style": "default"
                 }
             },

module/ios/module.a

@@ -1,8 +1,8 @@
 {
-    "changes": "* `fullscreen` config section deprecated in favor of new config section: `statusbar`\n* New API method: `setStatusBarStyle`\n* New config option: `display.statusbar.ios.style`\n* Android 'P' support",
+    "changes": "* Add new value for `forge.display.setStatusBarStyle` on iOS: `dark_content`",
     "description": "Configure display behaviour, like rotation and fullscreen, for your app.\n\nThis module also let you programmatically access and set device specific display options.",
-    "min_platform_version": "v2.7.1",
+    "min_platform_version": "v2.8.2",
     "namespace": "display",
-    "platform_version": "v2.7.1",
-    "version": "2.11"
+    "platform_version": "v2.8.2",
+    "version": "2.12"
 }

module/manifest.json

@@ -30,9 +30,9 @@ asyncTest("Status bar visible", 1, function() {
 });
 
 if (forge.is.ios()) {
-    asyncTest("Set status bar style, iOS", 1, function() {
-        forge.display.setStatusBarStyle("light_content", function () {
-            askQuestion("Status bar should be black with white text", {
+    asyncTest("Set status bar style UIStatusBarStyleLightContent, iOS", 1, function() {
+        forge.display.setStatusBarStyle("UIStatusBarStyleLightContent", function () {
+            askQuestion("Status bar should use light text", {
                 Yes: function () {
                     ok(true, "User claims success");
                     start();
@@ -48,9 +48,27 @@ if (forge.is.ios()) {
         });
     });
 
-    asyncTest("Set status bar style, iOS", 1, function() {
-        forge.display.setStatusBarStyle("default", function () {
-            askQuestion("Status bar should be white with black text", {
+    asyncTest("Set status bar style UIStatusBarStyleDarkContent, iOS", 1, function() {
+        forge.display.setStatusBarStyle("UIStatusBarStyleDarkContent", function () {
+            askQuestion("Status bar should use dark text", {
+                Yes: function () {
+                    ok(true, "User claims success");
+                    start();
+                },
+                No: function () {
+                    ok(false, "User claims failure");
+                    start();
+                }
+            });
+        }, function () {
+            ok(true, "Not available");
+            start();
+        });
+    });
+
+    asyncTest("Set status bar style UIStatusBarStyleDefault, iOS", 1, function() {
+        forge.display.setStatusBarStyle("UIStatusBarStyleDefault", function () {
+            askQuestion("Status bar should use a text color appropriate for dark mode", {
                 Yes: function () {
                     ok(true, "User claims success");
                     start();