Skip to content

Commit fe7ed4d

Browse files
morimotobroonie
authored andcommitted
ASoC: simple-card: rename to asoc_simple_card_canonicalize_platform()
Current simple-card is using asoc_simple_card_canonicalize_dailink(). Its naming is "dailink", but is for "platform". We already have asoc_simple_card_canonicalize_cpu() for "cpu", let's follow same naming rule. It never return error, so, void function is better idea. Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com> Signed-off-by: Mark Brown <broonie@kernel.org>
1 parent 10dff9b commit fe7ed4d

4 files changed

Lines changed: 9 additions & 22 deletions

File tree

include/sound/simple_card_utils.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -108,7 +108,7 @@ int asoc_simple_card_parse_graph_dai(struct device_node *ep,
108108
int asoc_simple_card_init_dai(struct snd_soc_dai *dai,
109109
struct asoc_simple_dai *simple_dai);
110110

111-
int asoc_simple_card_canonicalize_dailink(struct snd_soc_dai_link *dai_link);
111+
void asoc_simple_card_canonicalize_platform(struct snd_soc_dai_link *dai_link);
112112
void asoc_simple_card_canonicalize_cpu(struct snd_soc_dai_link *dai_link,
113113
int is_single_links);
114114

sound/soc/generic/audio-graph-card.c

Lines changed: 3 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -307,14 +307,12 @@ static int graph_dai_link_of_dpcm(struct graph_priv *priv,
307307
"prefix");
308308
}
309309

310+
asoc_simple_card_canonicalize_platform(dai_link);
311+
310312
ret = asoc_simple_card_of_parse_tdm(ep, dai);
311313
if (ret)
312314
return ret;
313315

314-
ret = asoc_simple_card_canonicalize_dailink(dai_link);
315-
if (ret < 0)
316-
return ret;
317-
318316
ret = asoc_simple_card_parse_daifmt(dev, cpu_ep, codec_ep,
319317
NULL, &dai_link->dai_fmt);
320318
if (ret < 0)
@@ -405,10 +403,6 @@ static int graph_dai_link_of(struct graph_priv *priv,
405403
if (ret < 0)
406404
return ret;
407405

408-
ret = asoc_simple_card_canonicalize_dailink(dai_link);
409-
if (ret < 0)
410-
return ret;
411-
412406
ret = asoc_simple_card_set_dailink_name(dev, dai_link,
413407
"%s-%s",
414408
dai_link->cpu_dai_name,
@@ -419,6 +413,7 @@ static int graph_dai_link_of(struct graph_priv *priv,
419413
dai_link->ops = &graph_ops;
420414
dai_link->init = graph_dai_init;
421415

416+
asoc_simple_card_canonicalize_platform(dai_link);
422417
asoc_simple_card_canonicalize_cpu(dai_link,
423418
of_graph_get_endpoint_count(dai_link->cpu_of_node) == 1);
424419

sound/soc/generic/simple-card-utils.c

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -394,16 +394,13 @@ int asoc_simple_card_init_dai(struct snd_soc_dai *dai,
394394
}
395395
EXPORT_SYMBOL_GPL(asoc_simple_card_init_dai);
396396

397-
int asoc_simple_card_canonicalize_dailink(struct snd_soc_dai_link *dai_link)
397+
void asoc_simple_card_canonicalize_platform(struct snd_soc_dai_link *dai_link)
398398
{
399399
/* Assumes platform == cpu */
400400
if (!dai_link->platforms->of_node)
401401
dai_link->platforms->of_node = dai_link->cpu_of_node;
402-
403-
return 0;
404-
405402
}
406-
EXPORT_SYMBOL_GPL(asoc_simple_card_canonicalize_dailink);
403+
EXPORT_SYMBOL_GPL(asoc_simple_card_canonicalize_platform);
407404

408405
void asoc_simple_card_canonicalize_cpu(struct snd_soc_dai_link *dai_link,
409406
int is_single_links)

sound/soc/generic/simple-card.c

Lines changed: 3 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -297,14 +297,12 @@ static int simple_dai_link_of_dpcm(struct simple_priv *priv,
297297

298298
simple_get_conversion(dev, np, &dai_props->adata);
299299

300+
asoc_simple_card_canonicalize_platform(dai_link);
301+
300302
ret = asoc_simple_card_of_parse_tdm(np, dai);
301303
if (ret)
302304
return ret;
303305

304-
ret = asoc_simple_card_canonicalize_dailink(dai_link);
305-
if (ret < 0)
306-
return ret;
307-
308306
snprintf(prop, sizeof(prop), "%smclk-fs", prefix);
309307
of_property_read_u32(top, PREFIX "mclk-fs", &dai_props->mclk_fs);
310308
of_property_read_u32(node, prop, &dai_props->mclk_fs);
@@ -409,10 +407,6 @@ static int simple_dai_link_of(struct simple_priv *priv,
409407
if (ret < 0)
410408
goto dai_link_of_err;
411409

412-
ret = asoc_simple_card_canonicalize_dailink(dai_link);
413-
if (ret < 0)
414-
goto dai_link_of_err;
415-
416410
ret = asoc_simple_card_set_dailink_name(dev, dai_link,
417411
"%s-%s",
418412
dai_link->cpu_dai_name,
@@ -424,6 +418,7 @@ static int simple_dai_link_of(struct simple_priv *priv,
424418
dai_link->init = simple_dai_init;
425419

426420
asoc_simple_card_canonicalize_cpu(dai_link, single_cpu);
421+
asoc_simple_card_canonicalize_platform(dai_link);
427422

428423
dai_link_of_err:
429424
of_node_put(node);

0 commit comments

Comments
 (0)