seq: Fix bogus return of snd_seq_client_info_get_ump_conversion()

tiwai · tiwai · commit df8f1cc1ec9d · 2025-02-17T12:06:09.000+01:00
snd_seq_client_info_get_ump_conversion() should have returned the proper bit of group_filter bit field, but it just did return midi_version field -- a stupid copy & paste error. Let's fix it. Fixes: 2aefb5c ("seq: Add UMP support") Signed-off-by: Takashi Iwai <tiwai@suse.de>
diff --git a/src/seq/seq.c b/src/seq/seq.c
@@ -1870,7 +1870,7 @@ int snd_seq_client_info_get_ump_groupless_enabled(const snd_seq_client_info_t *i
 int snd_seq_client_info_get_ump_conversion(const snd_seq_client_info_t *info)
 {
 	assert(info);
-	return info->midi_version;
+	return !(info->group_filter & SNDRV_SEQ_FILTER_NO_CONVERT);
 }
 
 /**

Original file line number	Diff line number	Diff line change
`@@ -1870,7 +1870,7 @@ int snd_seq_client_info_get_ump_groupless_enabled(const snd_seq_client_info_t *i`
`1870`	`1870`	`int snd_seq_client_info_get_ump_conversion(const snd_seq_client_info_t *info)`
`1871`	`1871`	`{`
`1872`	`1872`	`assert(info);`
`1873`		`- return info->midi_version;`
	`1873`	`+ return !(info->group_filter & SNDRV_SEQ_FILTER_NO_CONVERT);`
`1874`	`1874`	`}`
`1875`	`1875`
`1876`	`1876`	`/**`