Skip to content

Improve error message when model base path is missing #4128

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Sraman01-code wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Improve error message when model base path is missing #4128

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions tensorflow_serving/sources/storage_path/file_system_storage_path_source.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -256,9 +256,13 @@ absl::Status PollFileSystemForServable(
// returns an empty list instead of erring if the base path isn't found.)
absl::Status status = Env::Default()->FileExists(servable.base_path());
if (!status.ok()) {
return errors::InvalidArgument(
"Could not find base path ", servable.base_path(), " for servable ",
servable.servable_name(), " with error ", status.ToString());
return errors::NotFound(
"Could not find base path ", servable.base_path(),
" for servable ", servable.servable_name(),
". TensorFlow Serving expects the following directory structure:\n"
" <base_path>/<version>/saved_model.pb\n"
"Where <version> is a numeric directory name (e.g. '1').\n"
"Underlying filesystem error: ", status.ToString());
}

if (servable.servable_version_policy().policy_choice_case() ==
Expand Down