From 3f30212ca669d53d2175484098c1c743ba76158e Mon Sep 17 00:00:00 2001 From: "dependabot[bot]" <49699333+dependabot[bot]@users.noreply.github.com> Date: Fri, 11 Sep 2026 15:21:01 +0000 Subject: [PATCH 1/2] Bump the all-nuget group with 3 updates Bumps Microsoft.Build.Framework from 18.9.6 to 18.10.1 Bumps Microsoft.Build.Utilities.Core from 18.9.6 to 18.10.1 Bumps SlangDxcBundle.Toolchain from 2026.17.0 to 2026.17.1 --- updated-dependencies: - dependency-name: Microsoft.Build.Framework dependency-version: 18.10.1 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: all-nuget - dependency-name: Microsoft.Build.Utilities.Core dependency-version: 18.10.1 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: all-nuget - dependency-name: SlangDxcBundle.Toolchain dependency-version: 2026.17.1 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: all-nuget ... Signed-off-by: dependabot[bot] --- Directory.Packages.props | 6 +++--- src/Pixely.SdlangCompiler/build/Pixely.SdlangCompiler.props | 2 +- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/Directory.Packages.props b/Directory.Packages.props index cd66084b..8b0370ed 100644 --- a/Directory.Packages.props +++ b/Directory.Packages.props @@ -7,8 +7,8 @@ - - + + @@ -20,7 +20,7 @@ - + diff --git a/src/Pixely.SdlangCompiler/build/Pixely.SdlangCompiler.props b/src/Pixely.SdlangCompiler/build/Pixely.SdlangCompiler.props index e9afaeff..826ec2db 100644 --- a/src/Pixely.SdlangCompiler/build/Pixely.SdlangCompiler.props +++ b/src/Pixely.SdlangCompiler/build/Pixely.SdlangCompiler.props @@ -7,7 +7,7 @@ - 2026.17.0 + 2026.17.1 $(SlangDxcToolchainRoot)$(SlangPlatform)/ slangc slangc.exe From 8c2563f52a3a8b7e684f6c95b8ff0b6e1623cb59 Mon Sep 17 00:00:00 2001 From: botoddly <250804054+botoddly@users.noreply.github.com> Date: Fri, 11 Sep 2026 20:39:54 +0200 Subject: [PATCH 2/2] Make SdlangCompileTask.InputFile required and drop the unreachable empty-input guard --- src/Pixely.SdlangCompiler/SdlangCompileTask.cs | 10 +++------- .../SdlangCompileTaskTests.cs | 14 -------------- 2 files changed, 3 insertions(+), 21 deletions(-) diff --git a/src/Pixely.SdlangCompiler/SdlangCompileTask.cs b/src/Pixely.SdlangCompiler/SdlangCompileTask.cs index 7f72b68f..ddd602ba 100644 --- a/src/Pixely.SdlangCompiler/SdlangCompileTask.cs +++ b/src/Pixely.SdlangCompiler/SdlangCompileTask.cs @@ -13,9 +13,10 @@ public class SdlangCompileTask : Microsoft.Build.Utilities.Task private static readonly string[] GeneratedShaderExtensions = ["spv", "dxil", "metal"]; /// - /// The input shader file to compile. If empty or null, the task succeeds without compiling. + /// The input shader file to compile. /// - public string? InputFile { get; set; } + [Required] + public string InputFile { get; set; } = ""; /// /// Path to the slangc executable. Slang is build-time tooling, so it is located through this @@ -35,11 +36,6 @@ public override bool Execute() { GeneratedFiles = []; - if (string.IsNullOrEmpty(InputFile)) - { - return true; - } - if (string.IsNullOrEmpty(SlangCompilerPath)) { Log.LogError( diff --git a/tests/Pixely.SdlangCompiler.Tests/SdlangCompileTaskTests.cs b/tests/Pixely.SdlangCompiler.Tests/SdlangCompileTaskTests.cs index 5a0dc0c7..cf3f608e 100644 --- a/tests/Pixely.SdlangCompiler.Tests/SdlangCompileTaskTests.cs +++ b/tests/Pixely.SdlangCompiler.Tests/SdlangCompileTaskTests.cs @@ -24,18 +24,4 @@ public void CompiledShaderOutputExists() Assert.That(File.Exists(metadataPath), Is.True, "Compiled shader output file should exist at: " + metadataPath); } } - - [Test] - public void Execute_WithNullInputFile_ReturnsTrue() - { - SdlangCompileTask task = new SdlangCompileTask { InputFile = null }; - Assert.That(task.Execute(), Is.True); - } - - [Test] - public void Execute_WithEmptyInputFile_ReturnsTrue() - { - SdlangCompileTask task = new SdlangCompileTask { InputFile = "" }; - Assert.That(task.Execute(), Is.True); - } }