publish rust: semver option#28
Merged
Merged
Conversation
joncinque
approved these changes
Apr 2, 2026
Contributor
joncinque
left a comment
joncinque
left a comment
There was a problem hiding this comment.
Looks good to me! And since we'll need to update the downstream repos to pass it, making it not required makes the most sense too.
Just a question on the check, but not blocking this change
|
|
||
| - name: Check semver | ||
| if: ${{ steps.has_lib.outputs.has_lib == 'true' }} | ||
| if: ${{ steps.has_lib.outputs.has_lib == 'true' && inputs.run-semver }} |
Contributor
There was a problem hiding this comment.
I'm never sure how yaml works to be honest, but in the sdk we do inputs.run-semver == 'true' -- do we not need to be that pedantic?
Member
Author
There was a problem hiding this comment.
The docs says that "inputs context preserves Boolean values as Booleans".
But for outputs "steps.<step_id>.outputs.<output_name>: string. So this strange looking mixed expression is correct.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Provides consumers the ability to opt out of semver checks.
Relevant to https://github.com/solana-program/libraries/actions/runs/23888453532 where it's attempting a version that knowingly does not pass the check.