Repository navigation
chore(types): make RemoteSocket.data type safe - #4234
Merged
darrachequesne merged 4 commits intoJan 6, 2022
Merged
Conversation
Contributor
Author
|
Ah formatting. Will fix soon |
OrkhanAlikhanov
force-pushed
the
remote-socket-data-type
branch
from
January 3, 2022 21:14
6575691 to
b0e7d46
Compare
| * | ||
| * @public | ||
| */ | ||
| public fetchSockets(): Promise<RemoteSocket<EmitEvents>[]> { |
Member
There was a problem hiding this comment.
So we would have:
const sockets = await io.fetchSockets();
// with the BroadcastOperator
const sockets = await io.in("room-1").fetchSockets<SocketData>();Is that right?
Contributor
Author
There was a problem hiding this comment.
Exactly. We loss the SocketData type when BroadcastOperator is created, so it has to be specified. Otherwise it will default to any
Member
There was a problem hiding this comment.
In that case, I think it would make more sense to go with your first solution here, so we have the same API with and without operator (like to() or except()).
const sockets = await io.fetchSockets();
const sockets = await io.in("room-1").fetchSockets(); // no additional typesWhat do you think?
Contributor
Author
There was a problem hiding this comment.
Sounds good to me. Will update the PR
Member
|
@OrkhanAlikhanov awesome, thanks a lot 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds #4229 (comment)