From 2ed246c4a80fe7bc2e657c2747dd7b52e6c7be17 Mon Sep 17 00:00:00 2001 From: Kazuhiro Sera Date: Wed, 21 Jul 2021 16:57:43 +0900 Subject: [PATCH 1/2] Fix type hint errors detected by pytype 2021.7.19 --- slack_bolt/adapter/aws_lambda/local_lambda_client.py | 2 +- slack_bolt/authorization/authorize.py | 1 + slack_bolt/middleware/ssl_check/ssl_check.py | 8 ++++++-- 3 files changed, 8 insertions(+), 3 deletions(-) diff --git a/slack_bolt/adapter/aws_lambda/local_lambda_client.py b/slack_bolt/adapter/aws_lambda/local_lambda_client.py index 82181062e..92abf0c32 100644 --- a/slack_bolt/adapter/aws_lambda/local_lambda_client.py +++ b/slack_bolt/adapter/aws_lambda/local_lambda_client.py @@ -14,7 +14,7 @@ def __init__(self, app: Chalice, config: Config) -> None: def invoke( self, - FunctionName: str = None, + FunctionName: str, InvocationType: str = "Event", Payload: str = "{}", ) -> InvokeResponse: diff --git a/slack_bolt/authorization/authorize.py b/slack_bolt/authorization/authorize.py index c0627940e..537c51bd0 100644 --- a/slack_bolt/authorization/authorize.py +++ b/slack_bolt/authorization/authorize.py @@ -42,6 +42,7 @@ def __init__( self.arg_names = inspect.getfullargspec(func).args def __call__( + self, *, context: BoltContext, diff --git a/slack_bolt/middleware/ssl_check/ssl_check.py b/slack_bolt/middleware/ssl_check/ssl_check.py index 33be2bf63..e02ec7881 100644 --- a/slack_bolt/middleware/ssl_check/ssl_check.py +++ b/slack_bolt/middleware/ssl_check/ssl_check.py @@ -1,4 +1,5 @@ -from typing import Callable +from logging import Logger +from typing import Callable, Optional from slack_bolt.logger import get_bolt_logger from slack_bolt.middleware.middleware import Middleware @@ -7,7 +8,10 @@ class SslCheck(Middleware): # type: ignore - def __init__(self, verification_token: str = None): + verification_token: Optional[str] + logger: Logger + + def __init__(self, verification_token: Optional[str] = None): """Handles `ssl_check` requests. Refer to https://api.slack.com/interactivity/slash-commands for details. From e21e0a5a10a703d770f3b78284eafaecfec7d22f Mon Sep 17 00:00:00 2001 From: Kazuhiro Sera Date: Wed, 21 Jul 2021 17:08:31 +0900 Subject: [PATCH 2/2] Revert an unnecessary change --- slack_bolt/authorization/authorize.py | 1 - 1 file changed, 1 deletion(-) diff --git a/slack_bolt/authorization/authorize.py b/slack_bolt/authorization/authorize.py index 537c51bd0..c0627940e 100644 --- a/slack_bolt/authorization/authorize.py +++ b/slack_bolt/authorization/authorize.py @@ -42,7 +42,6 @@ def __init__( self.arg_names = inspect.getfullargspec(func).args def __call__( - self, *, context: BoltContext,