Add NGINX_ACCESS_LOG and NGINX_ERROR_LOG#534
Conversation
NGINX_ACCESS_LOG and NGINX_ERROR_LOGNGINX_ACCESS_LOG and NGINX_ERROR_LOG
|
Sorry for the hiccup here, but could you try creating a new PR? I had to move things in GitHub it automatically closed this PR. I don't see where I can update the branch into https://github.com/serversideup/docker-php/tree/280-create-a-frankenphp-variation It won't let me change it when I press edit. |
|
NVM, I got it. I accidentally deleted the source branch. That's why it closed. I will be reviewing this for 4.0 and will keep you posted 👍 Sorry for the confusion! |
|
@jaydrogers thanks for considering this for v4 ❤️ |
|
Thanks for your patience! I made some updates so this is compatible with our new v4.0 release: Just a note on not using
|
This is my first contribution. Let me know if something can be adjusted.
Targeting
release/v3.6I kept the default current values (
/dev/stdoutand/dev/stderr). But, honestly I would change it to the Nginx defaults.Because, it is not useful to have all that logs on the main stdout. But if you don't think so, it is all good to be merged.
Usage