add interface unit tests

Author: colinlyguo

encoding/codecv1_types.go

@@ -121,28 +121,6 @@ func (b *daBatchV1) Hash() common.Hash {
 	return crypto.Keccak256Hash(bytes)
 }
 
-// BlobDataProof computes the abi-encoded blob verification data.
-func (b *daBatchV1) BlobDataProof() ([]byte, error) {
-	if b.blob == nil {
-		return nil, errors.New("called BlobDataProof with empty blob")
-	}
-	if b.z == nil {
-		return nil, errors.New("called BlobDataProof with empty z")
-	}
-
-	commitment, err := kzg4844.BlobToCommitment(b.blob)
-	if err != nil {
-		return nil, fmt.Errorf("failed to create blob commitment: %w", err)
-	}
-
-	proof, y, err := kzg4844.ComputeProof(b.blob, *b.z)
-	if err != nil {
-		return nil, fmt.Errorf("failed to create KZG proof at point, err: %w, z: %v", err, hex.EncodeToString(b.z[:]))
-	}
-
-	return blobDataProofFromValues(*b.z, y, commitment, proof), nil
-}
-
 // Blob returns the blob of the batch.
 func (b *daBatchV1) Blob() *kzg4844.Blob {
 	return b.blob

encoding/interfaces_test.go

@@ -0,0 +1,117 @@
+package encoding
+
+import (
+	"math/big"
+	"testing"
+
+	"github.com/scroll-tech/go-ethereum/params"
+	"github.com/stretchr/testify/assert"
+)
+
+func TestCodecFromVersion(t *testing.T) {
+	tests := []struct {
+		name    string
+		version CodecVersion
+		want    Codec
+		wantErr bool
+	}{
+		{"CodecV0", CodecV0, &DACodecV0{}, false},
+		{"CodecV1", CodecV1, &DACodecV1{}, false},
+		{"CodecV2", CodecV2, &DACodecV2{}, false},
+		{"CodecV3", CodecV3, &DACodecV3{}, false},
+		{"CodecV4", CodecV4, &DACodecV4{}, false},
+		{"InvalidCodec", CodecVersion(99), nil, true},
+	}
+
+	for _, tt := range tests {
+		t.Run(tt.name, func(t *testing.T) {
+			got, err := CodecFromVersion(tt.version)
+			if tt.wantErr {
+				assert.Error(t, err)
+			} else {
+				assert.NoError(t, err)
+				assert.IsType(t, tt.want, got)
+			}
+		})
+	}
+}
+
+func TestCodecFromConfig(t *testing.T) {
+	tests := []struct {
+		name      string
+		config    *params.ChainConfig
+		blockNum  *big.Int
+		timestamp uint64
+		want      Codec
+	}{
+		{
+			name: "DarwinV2 active",
+			config: &params.ChainConfig{
+				LondonBlock:    big.NewInt(0),
+				BernoulliBlock: big.NewInt(0),
+				CurieBlock:     big.NewInt(0),
+				DarwinTime:     new(uint64),
+				DarwinV2Time:   new(uint64),
+			},
+			blockNum:  big.NewInt(0),
+			timestamp: 0,
+			want:      &DACodecV4{},
+		},
+		{
+			name: "Darwin active",
+			config: &params.ChainConfig{
+				LondonBlock:    big.NewInt(0),
+				BernoulliBlock: big.NewInt(0),
+				CurieBlock:     big.NewInt(0),
+				DarwinTime:     new(uint64),
+			},
+			blockNum:  big.NewInt(0),
+			timestamp: 0,
+			want:      &DACodecV3{},
+		},
+		{
+			name: "Curie active",
+			config: &params.ChainConfig{
+				LondonBlock:    big.NewInt(0),
+				BernoulliBlock: big.NewInt(0),
+				CurieBlock:     big.NewInt(0),
+			},
+			blockNum:  big.NewInt(0),
+			timestamp: 0,
+			want:      &DACodecV2{},
+		},
+		{
+			name: "Bernoulli active",
+			config: &params.ChainConfig{
+				LondonBlock:    big.NewInt(0),
+				BernoulliBlock: big.NewInt(0),
+			},
+			blockNum:  big.NewInt(0),
+			timestamp: 0,
+			want:      &DACodecV1{},
+		},
+		{
+			name: "London active",
+			config: &params.ChainConfig{
+				LondonBlock: big.NewInt(0),
+			},
+			blockNum:  big.NewInt(0),
+			timestamp: 0,
+			want:      &DACodecV0{},
+		},
+		{
+			name:      "No upgrades",
+			config:    &params.ChainConfig{},
+			blockNum:  big.NewInt(0),
+			timestamp: 0,
+			want:      &DACodecV0{},
+		},
+	}
+
+	for _, tt := range tests {
+		t.Run(tt.name, func(t *testing.T) {
+			got := CodecFromConfig(tt.config, tt.blockNum, tt.timestamp)
+			assert.IsType(t, tt.want, got)
+		})
+	}
+}