fix(desktop): preserve disabled update explanations across channels

Author: juliusmarminge

apps/desktop/src/updates/DesktopUpdates.test.ts

@@ -101,17 +101,35 @@ describe("DesktopUpdates", () => {
 
       const deb = yield* linuxState("deb\n");
       assert.equal(deb.status, "idle");
-      assert.equal(deb.message, null);
 
       const unmarked = yield* linuxState(undefined);
       assert.equal(unmarked.status, "disabled");
-      assert.equal(
-        unmarked.message,
-        "Automatic updates on Linux require the AppImage or the .deb package.",
-      );
     }),
   );
 
+  it.effect("keeps the disabled reason available after configuration and channel changes", () => {
+    const harness = makeHarness({ env: { T3CODE_DISABLE_AUTO_UPDATE: "true" } });
+    const reason = "Automatic updates are disabled by the T3CODE_DISABLE_AUTO_UPDATE setting.";
+
+    return Effect.scoped(
+      Effect.gen(function* () {
+        const updates = yield* DesktopUpdates.DesktopUpdates;
+        yield* updates.configure;
+
+        const configured = yield* updates.getState;
+        assert.equal(configured.message, reason);
+
+        const changed = yield* updates.setChannel("nightly");
+        assert.equal(changed.channel, "nightly");
+        assert.equal(changed.enabled, false);
+        assert.equal(changed.status, "disabled");
+        assert.equal(changed.message, reason);
+        assert.equal(harness.sentStates.at(-1)?.message, reason);
+        assert.equal(harness.checkCount(), 0);
+      }),
+    ).pipe(Effect.provide(harness.layer));
+  });
+
   it.effect("subscribe delivers the latest state plus subsequent changes", () => {
     const harness = makeHarness();
 

apps/web/src/components/desktopUpdate.logic.test.ts

@@ -410,9 +410,6 @@ describe("disabled update reason", () => {
       title: "Updates unavailable",
       detail: "Automatic updates are only available in packaged production builds.",
     });
-  });
-
-  it("falls back to a generic reason when the desktop app sent none", () => {
     expect(getDesktopUpdateDisabledReason({ ...disabledState, message: null })).toBe(
       "Automatic updates are not available in this build.",
     );

apps/web/src/components/desktopUpdate.logic.ts

@@ -149,21 +149,16 @@ export function canCheckForUpdate(state: DesktopUpdateState | null): boolean {
   );
 }
 
-/**
- * Why update checks are off, or null when they are available. The desktop app puts
- * the reason it computed into `message` when it builds the disabled state.
- */
 export function getDesktopUpdateDisabledReason(
   state: Pick<DesktopUpdateState, "enabled" | "status" | "message"> | null,
 ): string | null {
   if (!state || (state.enabled && state.status !== "disabled")) return null;
   return state.message?.trim() || "Automatic updates are not available in this build.";
 }
 
-/** Hover text for the update button when there is nothing to download or install. */
 export function getDesktopUpdateIdleTooltip(
   state: Pick<DesktopUpdateState, "enabled" | "status" | "message"> | null,
-): { readonly title: string; readonly detail: string | null } {
+) {
   const disabledReason = getDesktopUpdateDisabledReason(state);
   return disabledReason
     ? { title: "Updates unavailable", detail: disabledReason }

apps/web/src/components/settings/SettingsPanels.tsx

@@ -417,7 +417,6 @@ function AboutVersionSection() {
   };
   const buttonLabel =
     actionLabel[action] ?? statusLabel[updateState?.status ?? ""] ?? "Check for Updates";
-  // A disabled button has pointer-events: none, so the row explains why checks are off.
   const description =
     action === "download" || action === "install"
       ? "Update available."

apps/web/src/components/sidebar/SidebarUpdatePill.tsx

@@ -238,9 +238,7 @@ function SidebarUpdateControl() {
     showCheckIcon,
   });
   const idleTooltip =
-    !runsEverything && !showUpdateDetails && !showCheckIcon
-      ? getDesktopUpdateIdleTooltip(state)
-      : null;
+    !showUpdateDetails && !showCheckIcon ? getDesktopUpdateIdleTooltip(state) : null;
   const tooltip = runsEverything
     ? everything.summary
     : showUpdateDetails