Skip to content

remove the 'dereferenceable' attribute from Box#66645

Merged
bors merged 2 commits into
rust-lang:masterfrom
RalfJung:dereferenceable
Nov 29, 2019
Merged

remove the 'dereferenceable' attribute from Box#66645
bors merged 2 commits into
rust-lang:masterfrom
RalfJung:dereferenceable

Conversation

@RalfJung

Copy link
Copy Markdown
Member

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Nov 22, 2019
@jonas-schievink

Copy link
Copy Markdown
Contributor

@bors try

@bors

bors commented Nov 22, 2019

Copy link
Copy Markdown
Collaborator

⌛ Trying commit be07911 with merge d7c557381942c3cac82b5e4585f195ec369c2f68...

@RalfJung

Copy link
Copy Markdown
Member Author

@rust-timer queue

@rust-timer

Copy link
Copy Markdown
Collaborator

Awaiting bors try build completion

@bors

bors commented Nov 22, 2019

Copy link
Copy Markdown
Collaborator

☀️ Try build successful - checks-azure
Build commit: d7c557381942c3cac82b5e4585f195ec369c2f68 (d7c557381942c3cac82b5e4585f195ec369c2f68)

@rust-timer

Copy link
Copy Markdown
Collaborator

Queued d7c557381942c3cac82b5e4585f195ec369c2f68 with parent 083b5a0, future comparison URL.

@rust-timer

Copy link
Copy Markdown
Collaborator

Finished benchmarking try commit d7c557381942c3cac82b5e4585f195ec369c2f68, comparison URL.

@RalfJung

Copy link
Copy Markdown
Member Author

@Mark-Simulacrum this said "finished benchmarking" but there are no results at the comparison URL yet?

@bjorn3

bjorn3 commented Nov 23, 2019

Copy link
Copy Markdown
Member

@RalfJung It does now. It takes some time before the parent commit gets benchmarked after @rust-timer says it has finished benchmarking the child.

@RalfJung

Copy link
Copy Markdown
Member Author

I see.

Timings look like noise. But this is not necessarily a good benchmark.

Comment thread src/librustc_target/abi/call/mod.rs Outdated
Comment thread src/librustc/ty/layout.rs Outdated
Comment thread src/librustc/ty/layout.rs Outdated
@eddyb

eddyb commented Nov 26, 2019

Copy link
Copy Markdown
Contributor

r=me if there are no concerns left (e.g. perf)

@RalfJung

Copy link
Copy Markdown
Member Author

@pnkfelix so how do we proceed? I guess we should nominate this for T-lang and T-compiler discussion?

@pnkfelix

Copy link
Copy Markdown
Contributor

@bors r+ rollup=never

@bors

bors commented Nov 29, 2019

Copy link
Copy Markdown
Collaborator

📌 Commit d0b9833 has been approved by pnkfelix

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 29, 2019
@pnkfelix

Copy link
Copy Markdown
Contributor

(I marked as rollup=never because its not totally certain that there won't be performance regressions associated with this, and I'd rather pay the cost of an extra bors cycle up front than have to track that down in a rollup or have it otherwise masked by unrelated improvements in a rollup.)

bors added a commit that referenced this pull request Nov 29, 2019
remove the 'dereferenceable' attribute from Box

Fixes #66600

r? @eddyb @rkruppe
@bors

bors commented Nov 29, 2019

Copy link
Copy Markdown
Collaborator

⌛ Testing commit d0b9833 with merge c4375c9...

@bors

bors commented Nov 29, 2019

Copy link
Copy Markdown
Collaborator

☀️ Test successful - checks-azure
Approved by: pnkfelix
Pushing c4375c9 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Nov 29, 2019
@bors bors merged commit d0b9833 into rust-lang:master Nov 29, 2019
@RalfJung RalfJung deleted the dereferenceable branch November 29, 2019 19:26
@RalfJung RalfJung mentioned this pull request Apr 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Box is marked as "dereferenceable" for the duration of the call

9 participants