Skip to content

dragonflybsd: expose waitid() prototype + related constants - #2097

Closed
cmusser wants to merge 2 commits into
rust-lang:masterfrom
cmusser:topic/dfly-waitid
Closed

cmusser wants to merge 2 commits into
rust-lang:masterfrom
cmusser:topic/dfly-waitid

Conversation

@cmusser

@cmusser cmusser commented Mar 2, 2021

Copy link
Copy Markdown
Contributor

This exposes the POSIX waitid() process management function and some related defined constants for dragonflybsd. It includes one correction: WSTOPPED which previously had the wrong value. Noticed this when a crate that depended on it, process_control, wouldn't compile on this platform.

This exposes the POSIX waitid() process management function and some
related defined constants. It includes one correction: WSTOPPED which
previously had the wrong value.
@rust-highfive

Copy link
Copy Markdown

r? @Amanieu

(rust-highfive has picked a reviewer for you, use r? to override)

@Amanieu

Amanieu commented Mar 3, 2021

Copy link
Copy Markdown
Member

@bors r+

@bors

bors commented Mar 3, 2021

Copy link
Copy Markdown
Contributor

📌 Commit 6bfee3c has been approved by Amanieu

@bors

bors commented Mar 3, 2021

Copy link
Copy Markdown
Contributor

⌛ Testing commit 6bfee3c with merge a49576b...

bors added a commit that referenced this pull request Mar 3, 2021
dragonflybsd: expose waitid() prototype + related constants

This exposes the POSIX waitid() process management function and some related defined constants for dragonflybsd. It includes one correction: WSTOPPED which previously had the wrong value. Noticed this when a crate that depended on it, process_control, wouldn't compile on this platform.
@bors

bors commented Mar 3, 2021

Copy link
Copy Markdown
Contributor

💔 Test failed - checks-actions

@Amanieu

Amanieu commented Mar 3, 2021

Copy link
Copy Markdown
Member
2021-03-03T01:18:36.6123268Z error: constant is never used: `WNOHANG`
2021-03-03T01:18:36.6125425Z    --> src/unix/bsd/freebsdlike/dragonfly/mod.rs:986:1
2021-03-03T01:18:36.6126225Z     |
2021-03-03T01:18:36.6127157Z 986 | pub const WNOHANG: ::c_int = 0x1;
2021-03-03T01:18:36.6127572Z     | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
2021-03-03T01:18:36.6127831Z     |
2021-03-03T01:18:36.6128278Z note: the lint level is defined here
2021-03-03T01:18:36.6129087Z    --> src/lib.rs:18:38
2021-03-03T01:18:36.6129678Z     |
2021-03-03T01:18:36.6130047Z 18  | #![cfg_attr(libc_deny_warnings, deny(warnings))]
2021-03-03T01:18:36.6130436Z     |                                      ^^^^^^^^
2021-03-03T01:18:36.6130867Z     = note: `#[deny(dead_code)]` implied by `#[deny(warnings)]`
2021-03-03T01:18:36.6131187Z 
2021-03-03T01:18:36.6131545Z error: constant is never used: `WUNTRACED`
2021-03-03T01:18:36.6132183Z    --> src/unix/bsd/freebsdlike/dragonfly/mod.rs:987:1
2021-03-03T01:18:36.6132584Z     |
2021-03-03T01:18:36.6132905Z 987 | pub const WUNTRACED: ::c_int = 0x2;
2021-03-03T01:18:36.6133290Z     | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
2021-03-03T01:18:36.6133466Z 
2021-03-03T01:18:36.6521873Z error: aborting due to 2 previous errors

@cmusser

cmusser commented Mar 3, 2021

Copy link
Copy Markdown
Contributor Author

Oh, I missed that, unfortunately, but I can reproduce it here. If it's a pub const, why does it trip up if it's never used? I looked around for another constant (WEXITED) to see how it was used and I could only find its definition. How can it tell if something is used or not?

Comment thread src/unix/bsd/freebsdlike/dragonfly/mod.rs Outdated
These are already defined generally for BSD systemss
@JohnTitor

Copy link
Copy Markdown
Member

@bors r+ squash

@bors

bors commented Mar 3, 2021

Copy link
Copy Markdown
Contributor

📌 Commit 56c98cb has been approved by JohnTitor

bors added a commit that referenced this pull request Mar 3, 2021
dragonflybsd: expose waitid() prototype + related constants

This exposes the POSIX waitid() process management function and some related defined constants for dragonflybsd. It includes one correction: WSTOPPED which previously had the wrong value. Noticed this when a crate that depended on it, process_control, wouldn't compile on this platform.
@bors

bors commented Mar 3, 2021

Copy link
Copy Markdown
Contributor

⌛ Testing commit 56c98cb with merge ec86e5f...

@bors

bors commented Mar 3, 2021

Copy link
Copy Markdown
Contributor

☀️ Test successful - checks-actions, checks-cirrus-freebsd-11, checks-cirrus-freebsd-12, checks-cirrus-freebsd-13
Approved by: JohnTitor
Pushing ec86e5f to master...

@JohnTitor

Copy link
Copy Markdown
Member

Merged on master, thanks!

@JohnTitor JohnTitor closed this Mar 3, 2021
@cmusser

cmusser commented Mar 3, 2021

Copy link
Copy Markdown
Contributor Author

sure thing! thanks for the tip on fixing the PR

bors Bot referenced this pull request in codyps/rust-libzfs Mar 14, 2021
50: Bump libc from 0.2.81 to 0.2.88 r=jmesmon a=dependabot[bot]

Bumps [libc](https://github.com/rust-lang/libc) from 0.2.81 to 0.2.88.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/rust-lang/libc/releases">libc's releases</a>.</em></p>
<blockquote>
<h2>0.2.88</h2>
<p>Bump patch version to 0.2.88.</p>
<h2>0.2.87</h2>
<p>Bump patch version to 0.2.87.</p>
<h2>0.2.86</h2>
<p>Bump patch version to 0.2.86.</p>
<h2>0.2.82</h2>
<p>Bump patch version to 0.2.82.</p>
</blockquote>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a href="https://github.com/rust-lang/libc/commit/fc51a0f327ba148ffc1e6a11b7448f649b80608a"><code>fc51a0f</code></a> Auto merge of <a href="https://github.com/rust-lang/libc/issues/2103">#2103</a> - JohnTitor:version-bump, r=JohnTitor</li>
<li><a href="https://github.com/rust-lang/libc/commit/9abcbd15de9f281feea0a419e833958623a664f0"><code>9abcbd1</code></a> Bump up libc version to 0.2.88</li>
<li><a href="https://github.com/rust-lang/libc/commit/990afbb5adf9d6fd8d81202c7613f422ee61cf45"><code>990afbb</code></a> Auto merge of <a href="https://github.com/rust-lang/libc/issues/2102">#2102</a> - de-vri-es:linux-arm32-accept4, r=JohnTitor</li>
<li><a href="https://github.com/rust-lang/libc/commit/b98d5292b8cfe96213503997d9cd1f3f49bfce40"><code>b98d529</code></a> Re-add accept4 for Android on 32 bit ARM.</li>
<li><a href="https://github.com/rust-lang/libc/commit/3a7135f491b8faac564c13e7d0c5fd6b10e03855"><code>3a7135f</code></a> Auto merge of <a href="https://github.com/rust-lang/libc/issues/2100">#2100</a> - TheDoctor314:gettid, r=JohnTitor</li>
<li><a href="https://github.com/rust-lang/libc/commit/b719be41508f18b7abd7b521b7f555773c02d1fe"><code>b719be4</code></a> Skip tests for <code>gettid</code> on musl</li>
<li><a href="https://github.com/rust-lang/libc/commit/2de2cb74c82cde76a6b75ade8cf7e539052c7e2b"><code>2de2cb7</code></a> Add gettid() for Linux and Android</li>
<li><a href="https://github.com/rust-lang/libc/commit/ec86e5fb3258a844ece771d2c6f0fbf152086eab"><code>ec86e5f</code></a> Auto merge of <a href="https://github.com/rust-lang/libc/issues/2097">#2097</a> - cmusser:topic/dfly-waitid, r=JohnTitor</li>
<li><a href="https://github.com/rust-lang/libc/commit/c334f98ad97fdaa28f431b0c439686eef1048f3f"><code>c334f98</code></a> dragonflybsd: expose waitid() prototype + related constants</li>
<li><a href="https://github.com/rust-lang/libc/commit/6b1e6a2a72488481034fc2e1b409f379f96fd8f1"><code>6b1e6a2</code></a> Auto merge of <a href="https://github.com/rust-lang/libc/issues/2099">#2099</a> - JohnTitor:fix-doc-links, r=JohnTitor</li>
<li>Additional commits viewable in <a href="https://github.com/rust-lang/libc/compare/0.2.81...0.2.88">compare view</a></li>
</ul>
</details>
<br />


[![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=libc&package-manager=cargo&previous-version=0.2.81&new-version=0.2.88)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)

You can trigger a rebase of this PR by commenting `@dependabot rebase`.

[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)



Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants