From 69f0d6e37e1f88c4215bdcec1561823d1c5a3219 Mon Sep 17 00:00:00 2001 From: ksqsf Date: Fri, 14 Feb 2025 19:23:07 +0100 Subject: [PATCH 1/2] enhance(punctuator): commit on space after digit separators --- src/rime/gear/punctuator.cc | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/src/rime/gear/punctuator.cc b/src/rime/gear/punctuator.cc index 795ea16ded..a47773b4fe 100644 --- a/src/rime/gear/punctuator.cc +++ b/src/rime/gear/punctuator.cc @@ -96,13 +96,14 @@ ProcessResult Punctuator::ProcessKeyEvent(const KeyEvent& key_event) { if (ctx->get_option("ascii_punct")) { return kNoop; } - if (!use_space_ && ch == XK_space && ctx->IsComposing()) { - return kNoop; - } - if (isdigit(ch) && is_after_digit_separator(ctx)) { + if ((isdigit(ch) || (!use_space_ && ch == XK_space)) && + is_after_digit_separator(ctx)) { ctx->PushInput(ch) && ctx->Commit(); return kAccepted; } + if (!use_space_ && ch == XK_space && ctx->IsComposing()) { + return kNoop; + } if (ConvertDigitSeparator(ch)) { return kAccepted; } From 7f097c5d4c63a87dcfe510bfdff85793757aaae4 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?=E5=B1=85=E6=88=8E=E6=B0=8F?= Date: Sat, 15 Feb 2025 21:39:25 +0800 Subject: [PATCH 2/2] no respect to use_space after digit separator --- src/rime/gear/punctuator.cc | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/rime/gear/punctuator.cc b/src/rime/gear/punctuator.cc index a47773b4fe..94fb136fcb 100644 --- a/src/rime/gear/punctuator.cc +++ b/src/rime/gear/punctuator.cc @@ -96,8 +96,7 @@ ProcessResult Punctuator::ProcessKeyEvent(const KeyEvent& key_event) { if (ctx->get_option("ascii_punct")) { return kNoop; } - if ((isdigit(ch) || (!use_space_ && ch == XK_space)) && - is_after_digit_separator(ctx)) { + if ((isdigit(ch) || ch == XK_space) && is_after_digit_separator(ctx)) { ctx->PushInput(ch) && ctx->Commit(); return kAccepted; }