Skip to content

Commit 9060593

Browse files
committed
add more type annotations
1 parent 285ec6c commit 9060593

File tree

2 files changed

+25
-4
lines changed

2 files changed

+25
-4
lines changed

rerobots/api.py

Lines changed: 11 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@
1818
# only required for certain code paths that go beyond core routines.
1919
# e.g., get_snapshot_cam(dformat='array')
2020

21-
from .types import Capability
21+
from .types import AccessRules, Capability
2222

2323

2424
class Error(Exception):
@@ -241,7 +241,11 @@ def get_wdeployment_info(self, wdeployment_id: str):
241241
raise Error(res.text)
242242
return payload
243243

244-
def get_access_rules(self, wdeployment_id=None, to_user=None):
244+
def get_access_rules(
245+
self,
246+
wdeployment_id: str | None = None,
247+
to_user: str | None = None,
248+
) -> AccessRules:
245249
"""Get list of access control rules of workspace deployments."""
246250
params = dict()
247251
if to_user is not None:
@@ -292,7 +296,11 @@ def create_access_rule(
292296
raise Error('{} {}'.format(res.status_code, res.reason))
293297
return res.json()['rule_id']
294298

295-
def del_access_rule(self, wdeployment_id, rule_id) -> None:
299+
def del_access_rule(
300+
self,
301+
wdeployment_id: str,
302+
rule_id: int,
303+
) -> None:
296304
"""Delete access control rule from workspace deployment."""
297305
res = requests.delete(
298306
self.__base_uri + '/deployment/{}/rule/{}'.format(wdeployment_id, rule_id),

rerobots/types.py

Lines changed: 14 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,18 @@
1-
from typing import Literal
1+
from typing import Literal, TypedDict
22

33

44
Capability = Literal['CAP_NO_INSTANTIATE', 'CAP_INSTANTIATE']
55
InstanceStatus = Literal['INIT', 'INIT_FAIL', 'READY', 'TERMINATING', 'TERMINATED']
6+
7+
8+
class AccessRule(TypedDict):
9+
id: int
10+
date_created: str
11+
user: str
12+
wdeployment_id: str
13+
capability: Capability
14+
param: int
15+
16+
17+
class AccessRules(TypedDict):
18+
rules: list[AccessRule]

0 commit comments

Comments
 (0)