Conversation
|
Deploy preview for reactjs ready! Built with commit 16e166d |
Member
|
Can you add them temporarily to sidebar somewhere so that it’s easy to preview what you already posted on a live site? |
gaearon
reviewed
Jul 23, 2019
threepointone
force-pushed
the
testing-docs
branch
from
728a54f to
b917d4d
Compare
Contributor
Author
|
It's now under Advanced Guides > Testing |
This expands the testing docs for reactjs.org. It adds 4 main docs - - testing.md: An entry point to the testing docs - testing-recipes.md: Common patterns when writing tests for React Components. - testing-environments.md: Setting up your testing environment. - act.md: Notes on React's act() test helper. Once this is in place, we'll decide whether to add links to the sidebar, and further steps.
threepointone
force-pushed
the
testing-docs
branch
from
b917d4d to
af258c6
Compare
alexkrolick
reviewed
Jul 25, 2019
Thanks @alexkrolick! Co-Authored-By: Alex Krolick <alexkrolick@users.noreply.github.com>
threepointone
force-pushed
the
testing-docs
branch
from
b7e19cb to
fa7af1c
Compare
gaearon
reviewed
Jul 29, 2019
Member
gaearon
left a comment
gaearon
left a comment
There was a problem hiding this comment.
High level feedback: we need to use less jargon and be more concrete.
eddiecooro
reviewed
Jul 30, 2019
threepointone
force-pushed
the
testing-docs
branch
10 times, most recently
from
c4517ca to
b61cff5
Compare
threepointone
force-pushed
the
testing-docs
branch
from
b61cff5 to
f6b0b63
Compare
gaearon
approved these changes
Aug 8, 2019
Member
gaearon
left a comment
gaearon
left a comment
There was a problem hiding this comment.
Looks good. I did a small edit pass. Let's tweak examples as we discussed
threepointone
force-pushed
the
testing-docs
branch
from
bf00b82 to
e3d3125
Compare
threepointone
force-pushed
the
testing-docs
branch
from
e3d3125 to
16e166d
Compare
74 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This expands the testing docs for reactjs.org. It adds 3 main docs -
https://deploy-preview-2165--reactjs.netlify.com/docs/testing.html
https://deploy-preview-2165--reactjs.netlify.com/docs/testing-recipes.html
https://deploy-preview-2165--reactjs.netlify.com/docs/testing-environments.html