Fix more pylint warnings (#143)

Fix a spurious divide-by-zero error in sedov_compare.py and
gauss_diffusion_compare.py that pylint found. Most of the other fixes
are for `unused-variable`, plus some instances of
`consider-using-enumerate`, `consider-using-dict-items`,
`consider-iterating-dictionary`, `use-dict-literal`,
`useless-object-inheritance`, and `unneeded-not`.

Also disable `pointless-string-statement`, since these are used for
block comments in a couple places.

Author: yut23

pyproject.toml

@@ -20,6 +20,7 @@ disable = [
   "missing-class-docstring",
   "missing-function-docstring",
   "missing-module-docstring",
+  "pointless-string-statement",
 ]
 enable = [
   "useless-suppression",

pyro/advection/simulation.py

@@ -106,7 +106,7 @@ def dovis(self):
 
         myg = self.cc_data.grid
 
-        _, axes, cbar_title = plot_tools.setup_axes(myg, 1)
+        _, axes, _ = plot_tools.setup_axes(myg, 1)
 
         # plot density
         ax = axes[0]

pyro/advection_nonuniform/simulation.py

@@ -131,7 +131,7 @@ def dovis(self):
 
         myg = self.cc_data.grid
 
-        _, axes, cbar_title = plot_tools.setup_axes(myg, 1)
+        _, axes, _ = plot_tools.setup_axes(myg, 1)
 
         # plot density
         ax = axes[0]

pyro/analysis/convergence.py

@@ -27,7 +27,7 @@ def compare(fine, coarse):
 
 if __name__ == "__main__":
 
-    if not len(sys.argv) == 3:
+    if len(sys.argv) != 3:
         print(usage)
         sys.exit(2)
 

pyro/analysis/dam_compare.py

@@ -24,7 +24,7 @@ def abort(string):
     sys.exit(2)
 
 
-if not len(sys.argv) == 2:
+if len(sys.argv) != 2:
     print(usage)
     sys.exit(2)
 

pyro/analysis/gauss_diffusion_compare.py

@@ -88,7 +88,7 @@ def process(file):
     # now bin the associated data
     phi_bin = np.zeros(len(ncount)-1, dtype=np.float64)
 
-    for n in range(len(ncount)):
+    for n in range(1, len(ncount)):
 
         # remember that there are no whichbin == 0, since that
         # corresponds to the left edge.  So we want whichbin == 1 to
@@ -106,7 +106,7 @@ def process(file):
 
 if __name__ == "__main__":
 
-    if not len(sys.argv) >= 2:
+    if len(sys.argv) < 2:
         print(usage)
         sys.exit(2)
 

pyro/analysis/incomp_converge_error.py

@@ -16,7 +16,7 @@
 """
 
 
-if not len(sys.argv) == 2:
+if len(sys.argv) != 2:
     print(usage)
     sys.exit(2)
 

pyro/analysis/sedov_compare.py

@@ -100,7 +100,7 @@
 u_bin = np.zeros(len(ncount)-1, dtype=np.float64)
 p_bin = np.zeros(len(ncount)-1, dtype=np.float64)
 
-for n in range(len(ncount)):
+for n in range(1, len(ncount)):
 
     # remember that there are no whichbin == 0, since that corresponds
     # to the left edge.  So we want whichbin == 1 to correspond to the

pyro/analysis/smooth_error.py

@@ -16,7 +16,7 @@
       usage: ./smooth_error.py file
 """
 
-if not len(sys.argv) == 2:
+if len(sys.argv) != 2:
     print(usage)
     sys.exit(2)
 

pyro/analysis/sod_compare.py

@@ -21,7 +21,7 @@ def abort(string):
     sys.exit(2)
 
 
-if not len(sys.argv) == 2:
+if len(sys.argv) != 2:
     print(usage)
     sys.exit(2)