Skip to content

Commit 27e5e89

Browse files
authored
HDDS-11122. Fix javadoc warnings (apache#7234)
(cherry picked from commit 70e6e40)
1 parent 17df0a0 commit 27e5e89

72 files changed

Lines changed: 91 additions & 104 deletions

File tree

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

hadoop-hdds/client/src/main/java/org/apache/hadoop/hdds/scm/storage/BlockDataStreamOutput.java

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -364,7 +364,6 @@ public void writeOnRetry(long len) throws IOException {
364364
* it is a no op.
365365
* @param bufferFull flag indicating whether bufferFull condition is hit or
366366
* its called as part flush/close
367-
* @return minimum commit index replicated to all nodes
368367
* @throws IOException IOException in case watch gets timed out
369368
*/
370369
public void watchForCommit(boolean bufferFull) throws IOException {

hadoop-hdds/client/src/main/java/org/apache/hadoop/ozone/client/io/BlockInputStreamFactory.java

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,6 @@ public interface BlockInputStreamFactory {
4343
* @param blockInfo The blockInfo representing the block.
4444
* @param pipeline The pipeline to be used for reading the block
4545
* @param token The block Access Token
46-
* @param verifyChecksum Whether to verify checksums or not.
4746
* @param xceiverFactory Factory to create the xceiver in the client
4847
* @param refreshFunction Function to refresh the block location if needed
4948
* @return BlockExtendedInputStream of the correct type.

hadoop-hdds/client/src/main/java/org/apache/hadoop/ozone/client/io/BlockInputStreamFactoryImpl.java

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -71,7 +71,6 @@ public BlockInputStreamFactoryImpl(ByteBufferPool byteBufferPool,
7171
* @param blockInfo The blockInfo representing the block.
7272
* @param pipeline The pipeline to be used for reading the block
7373
* @param token The block Access Token
74-
* @param verifyChecksum Whether to verify checksums or not.
7574
* @param xceiverFactory Factory to create the xceiver in the client
7675
* @param refreshFunction Function to refresh the pipeline if needed
7776
* @return BlockExtendedInputStream of the correct type.

hadoop-hdds/client/src/main/java/org/apache/hadoop/ozone/client/io/ECBlockInputStreamFactory.java

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,6 @@ public interface ECBlockInputStreamFactory {
4545
* know are bad and should not be used.
4646
* @param repConfig The replication Config
4747
* @param blockInfo The blockInfo representing the block.
48-
* @param verifyChecksum Whether to verify checksums or not.
4948
* @param xceiverFactory Factory to create the xceiver in the client
5049
* @param refreshFunction Function to refresh the block location if needed
5150
* @return BlockExtendedInputStream of the correct type.

hadoop-hdds/client/src/main/java/org/apache/hadoop/ozone/client/io/ECBlockInputStreamFactoryImpl.java

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -68,7 +68,6 @@ private ECBlockInputStreamFactoryImpl(BlockInputStreamFactory streamFactory,
6868
* know are bad and should not be used.
6969
* @param repConfig The replication Config
7070
* @param blockInfo The blockInfo representing the block.
71-
* @param verifyChecksum Whether to verify checksums or not.
7271
* @param xceiverFactory Factory to create the xceiver in the client
7372
* @param refreshFunction Function to refresh the pipeline if needed
7473
* @return BlockExtendedInputStream of the correct type.

hadoop-hdds/client/src/main/java/org/apache/hadoop/ozone/client/io/ECBlockReconstructedStripeInputStream.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -85,7 +85,7 @@
8585
* Parity elements long. Missing or not needed elements should be set to null
8686
* in the array. The elements should be assigned to the array in EC index order.
8787
*
88-
* Assuming we have n missing data locations, where n <= parity locations, the
88+
* Assuming we have n missing data locations, where n {@literal <=} parity locations, the
8989
* ByteBuffers passed in from the client are either assigned to the decoder
9090
* input array, or they are assigned to the decoder output array, where
9191
* reconstructed data is written. The required number of parity buffers will be

hadoop-hdds/common/src/main/java/org/apache/hadoop/hdds/annotation/InterfaceStability.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -27,9 +27,9 @@
2727
* class or method not changing over time. Currently the stability can be
2828
* {@link Stable}, {@link Evolving} or {@link Unstable}. <br>
2929
*
30-
* <ul><li>All classes that are annotated with {@link Public} or
31-
* {@link LimitedPrivate} must have InterfaceStability annotation. </li>
32-
* <li>Classes that are {@link Private} are to be considered unstable unless
30+
* <ul><li>All classes that are annotated with {@link InterfaceAudience.Public} or
31+
* {@link InterfaceAudience.LimitedPrivate} must have InterfaceStability annotation. </li>
32+
* <li>Classes that are {@link InterfaceAudience.Private} are to be considered unstable unless
3333
* a different InterfaceStability annotation states otherwise.</li>
3434
* <li>Incompatible changes must not be made to classes marked as stable.</li>
3535
* </ul>

hadoop-hdds/common/src/main/java/org/apache/hadoop/hdds/recon/ReconConfigKeys.java

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -20,11 +20,13 @@
2020

2121
/**
2222
* This class contains constants for Recon related configuration keys used in
23-
* SCM & Datanode.
23+
* SCM and Datanode.
2424
*/
2525
public final class ReconConfigKeys {
2626

2727
/**
28+
* This class contains constants for Recon related configuration keys used in
29+
* SCM and Datanode.
2830
* Never constructed.
2931
*/
3032
private ReconConfigKeys() {
@@ -71,7 +73,7 @@ private ReconConfigKeys() {
7173
* Recon administrator users delimited by a comma.
7274
* This is the list of users who can access admin only information from recon.
7375
* Users defined in
74-
* {@link org.apache.hadoop.ozone.OzoneConfigKeys.OZONE_ADMINISTRATORS}
76+
* {@link org.apache.hadoop.ozone.OzoneConfigKeys#OZONE_ADMINISTRATORS}
7577
* will always be able to access all recon information regardless of this
7678
* setting.
7779
*/

hadoop-hdds/common/src/main/java/org/apache/hadoop/hdds/scm/ScmConfig.java

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -206,8 +206,7 @@ public int getScmDefaultLayoutVersionOnInit() {
206206
* required for SCMSecurityProtocol where the KerberosInfo references
207207
* the old configuration with
208208
* the annotation shown below:-
209-
* @KerberosInfo(serverPrincipal = ScmConfigKeys
210-
* .HDDS_SCM_KERBEROS_PRINCIPAL_KEY)
209+
* {@code @KerberosInfo(serverPrincipal = ScmConfigKeys.HDDS_SCM_KERBEROS_PRINCIPAL_KEY)}
211210
*/
212211
public static class ConfigStrings {
213212
public static final String HDDS_SCM_KERBEROS_PRINCIPAL_KEY =

hadoop-hdds/common/src/main/java/org/apache/hadoop/hdds/scm/client/ScmClient.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -414,7 +414,7 @@ StartContainerBalancerResponseProto startContainerBalancer(
414414
* considered to be failed if it has been sent more than MAX_RETRY limit
415415
* and its count is reset to -1.
416416
*
417-
* @param count Maximum num of returned transactions, if < 0. return all.
417+
* @param count Maximum num of returned transactions, if {@literal < 0}. return all.
418418
* @param startTxId The least transaction id to start with.
419419
* @return a list of failed deleted block transactions.
420420
* @throws IOException

0 commit comments

Comments
 (0)