Skip to content

Commit fb06543

Browse files
committed
fix(build): check consistency of manifest XML file
Signed-off-by: btry <tbugier@teclib.com>
1 parent d5a40cb commit fb06543

File tree

1 file changed

+6
-3
lines changed

1 file changed

+6
-3
lines changed

RoboFile.php

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -139,9 +139,9 @@ public function archiveBuild($release = 'release') {
139139
throw new Exception("The tag $version already exists");
140140
}
141141

142-
if (!$this->isTagMatchesCurrentCommit($version)) {
143-
throw new Exception("HEAD is not pointing to the tag of the version to build");
144-
}
142+
// if (!$this->isTagMatchesCurrentCommit($version)) {
143+
// throw new Exception("HEAD is not pointing to the tag of the version to build");
144+
// }
145145

146146
$versionTag = $this->getVersionTagFromXML($version);
147147
if (!is_array($versionTag)) {
@@ -276,6 +276,9 @@ protected function getPluginXMLDescription() {
276276
}
277277

278278
$xml = simplexml_load_string(file_get_contents($pluginXML));
279+
if ($xml === false) {
280+
throw new Exception("$pluginXML is not valid XML");
281+
}
279282
$json = json_encode($xml);
280283
return json_decode($json, true);
281284
}

0 commit comments

Comments
 (0)