Skip to content

Commit cbc2249

Browse files
committed
fix(targetticket,targetchange): return value of save() method
1 parent 52934f1 commit cbc2249

File tree

3 files changed

+4
-4
lines changed

3 files changed

+4
-4
lines changed

inc/formanswer.class.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1081,7 +1081,7 @@ public function generateTarget() {
10811081
$targetObject = new $target['itemtype'];
10821082
$targetObject->getFromDB($target['items_id']);
10831083
$generatedTarget = $targetObject->save($this);
1084-
if ($generatedTarget === false) {
1084+
if ($generatedTarget === null) {
10851085
$success = false;
10861086
break;
10871087
}

inc/targetchange.class.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -932,7 +932,7 @@ public function prepareInputForUpdate($input) {
932932
*
933933
* @param PluginFormcreatorFormAnswer $formanswer Answers previously saved
934934
*
935-
* @return Change|false generated change
935+
* @return Change|null generated change
936936
*/
937937
public function save(PluginFormcreatorFormAnswer $formanswer) {
938938
global $DB;
@@ -1031,7 +1031,7 @@ public function save(PluginFormcreatorFormAnswer $formanswer) {
10311031

10321032
// Create the target change
10331033
if (!$changeID = $change->add($data)) {
1034-
return false;
1034+
return null;
10351035
}
10361036

10371037
// Add tag if presents

inc/targetticket.class.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1046,7 +1046,7 @@ public function pre_deleteItem() {
10461046
*
10471047
* @param PluginFormcreatorFormAnswer $formanswer Answers previously saved
10481048
*
1049-
* @return Ticket|false Generated ticket if success, null otherwise
1049+
* @return Ticket|null Generated ticket if success, null otherwise
10501050
*/
10511051
public function save(PluginFormcreatorFormAnswer $formanswer) {
10521052
global $DB, $CFG_GLPI;

0 commit comments

Comments
 (0)